Repository navigation
fix: TaskUpdatePackages should use finder - #16692
Merged
Merged
Conversation
The tasks should use finder for getting resources instead of using a XYZ.class.getClassLoader() as that doesn't contain required content.
Contributor
|
Kudos, SonarCloud Quality Gate passed!
|
Artur-
approved these changes
Apr 25, 2023
Collaborator
|
Hi @caalador and @Artur-, when i performed cherry-pick to this commit to 24.0, i have encountered the following issue. Can you take a look and pick it manually? |
caalador
added a commit
that referenced
this pull request
Apr 26, 2023
The tasks should use finder for getting resources instead of using a XYZ.class.getClassLoader() as that doesn't contain required content. Fixes #16032
caalador
added a commit
that referenced
this pull request
Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








The tasks should use finder for getting
resources instead of using a XYZ.class.getClassLoader() as
that doesn't contain required content.
This fixes the issue that a production build in maven/gradle
prints out
Unable to determine version information. No vaadin-core-versions.json foundFixes #16032