Skip to content

fix: TaskUpdatePackages should use finder - #16692

Merged
Artur- merged 3 commits into
mainfrom
issues/unable-to-find-versions
Apr 25, 2023
Merged

Artur- merged 3 commits into
mainfrom
issues/unable-to-find-versions

Conversation

@caalador

@caalador caalador commented Apr 25, 2023 •

Copy link
Copy Markdown
Contributor

The tasks should use finder for getting
resources instead of using a XYZ.class.getClassLoader() as
that doesn't contain required content.

This fixes the issue that a production build in maven/gradle
prints out Unable to determine version information. No vaadin-core-versions.json found

Fixes #16032

The tasks should use finder for getting
resources instead of using a XYZ.class.getClassLoader()
as that doesn't contain required content.
@github-actions

github-actions Bot commented Apr 25, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   982 files  +   196     982 suites  +196   1h 17m 48s ⏱️ + 5m 9s
6 178 tests +2 135  6 139 ✔️ +2 135  39 💤 +1  0 ❌  - 1 
6 429 runs  +2 152  6 383 ✔️ +2 150  46 💤 +3  0 ❌  - 1 

Results for commit 2acd148. ± Comparison against base commit ddf6076.

♻️ This comment has been updated with latest results.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artur-
Artur- enabled auto-merge (squash) April 25, 2023 11:33
@Artur-
Artur- merged commit d02762c into main Apr 25, 2023
@Artur-
Artur- deleted the issues/unable-to-find-versions branch April 25, 2023 11:45
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @caalador and @Artur-, when i performed cherry-pick to this commit to 24.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick d02762c
error: could not apply d02762c... fix: TaskUpdatePackages should use finder (#16692)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

caalador added a commit that referenced this pull request Apr 26, 2023
The tasks should use finder for getting
resources instead of using a XYZ.class.getClassLoader()
as that doesn't contain required content.

Fixes #16032
caalador added a commit that referenced this pull request Apr 28, 2023
The tasks should use finder for getting
resources instead of using a XYZ.class.getClassLoader()
as that doesn't contain required content.

Fixes #16032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version information warning when building for production

3 participants