Skip to content

fix: Import needed CSS helper in lazy chunks - #16737

Merged
Artur- merged 2 commits into
mainfrom
fix-test-eager
May 4, 2023
Merged

Artur- merged 2 commits into
mainfrom
fix-test-eager

Conversation

@Artur-

@Artur- Artur- commented May 4, 2023

Copy link
Copy Markdown
Member

No description provided.

mshabarov
mshabarov previously approved these changes May 4, 2023
@mshabarov
mshabarov enabled auto-merge (squash) May 4, 2023 07:51
czp13
czp13 previously approved these changes May 4, 2023
@github-actions

github-actions Bot commented May 4, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   985 files  +   196     985 suites  +196   1h 20m 51s ⏱️ + 11m 46s
6 241 tests +2 134  6 201 ✔️ +2 136  40 💤 +1  0 ❌  - 3 
6 489 runs  +2 145  6 444 ✔️ +2 147  45 💤 +1  0 ❌  - 3 

Results for commit 13f95a7. ± Comparison against base commit c5e2e57.

This pull request removes 2 and adds 2136 tests. Note that renamed tests count towards both.
com.vaadin.flow.server.frontend.UpdateImportsWithByteCodeScannerTest ‑ duplicateCssOnlyImportedOnce
com.vaadin.flow.server.frontend.UpdateImportsWithFullCPScannerTest ‑ duplicateCssOnlyImportedOnce
com.vaadin.base.devserver.AbstractDevServerRunnerTest ‑ shouldPassEncodedUrlToDevServer
com.vaadin.base.devserver.AbstractDevServerRunnerTest ‑ updateServerStartupEnvironment_preferIpv4_LocalhostIpAddressAddedToProcessEnvironment
com.vaadin.base.devserver.AbstractDevServerRunnerTest ‑ updateServerStartupEnvironment_preferIpv6_LocalhostIpAddressAddedToProcessEnvironment
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_devMode_contextHasNoReloadInstance_instanceIsCreated
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_devMode_contextHasReloadInstance_instanceIsReturned
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_liveReloadDisabled_instanceIsCreated
com.vaadin.base.devserver.BrowserLiveReloadAccessorImplTest ‑ getLiveReload_productionMode_nullIsReturned
com.vaadin.base.devserver.DebugWindowConnectionTest ‑ backwardsCompatibilityClassExists
com.vaadin.base.devserver.DebugWindowConnectionTest ‑ getBackend_HotSwapVaadinIntegrationClassLoaded_returnsHOTSWAP_AGENT
com.vaadin.base.devserver.DebugWindowConnectionTest ‑ getBackend_JRebelClassEventListenerClassLoaded_returnsJREBEL
…

♻️ This comment has been updated with latest results.

@Artur-
Artur- dismissed stale reviews from czp13 and mshabarov via 73b9f47 May 4, 2023 08:27
@Artur-
Artur- force-pushed the fix-test-eager branch from b2a846b to 73b9f47 Compare May 4, 2023 08:27
@Artur- Artur- changed the title test: Fix test expecting eager dependencies fix: Import needed CSS helper in lazy chunks May 4, 2023
@Artur-
Artur- disabled auto-merge May 4, 2023 08:27
@Artur-
Artur- enabled auto-merge (squash) May 4, 2023 08:28
@Artur-
Artur- requested a review from mshabarov May 4, 2023 08:28
@sonarqubecloud

sonarqubecloud Bot commented May 4, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artur-
Artur- merged commit 5bf62d7 into main May 4, 2023
@Artur-
Artur- deleted the fix-test-eager branch May 4, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants