Skip to content

fix: Restore JRebel support - #16758

Merged
Artur- merged 2 commits into
mainfrom
jrebel
May 9, 2023
Merged

Artur- merged 2 commits into
mainfrom
jrebel

Conversation

@Artur-

@Artur- Artur- commented May 9, 2023 •

Copy link
Copy Markdown
Member

JRebel detects BrowserLiveReloadAccess and uses it to trigger the browser reload

@github-actions

github-actions Bot commented May 9, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   986 files  +   197     986 suites  +197   1h 21m 11s ⏱️ + 11m 18s
6 242 tests +2 135  6 203 ✔️ +2 135  39 💤 +1  0 ❌  - 1 
6 491 runs  +2 148  6 447 ✔️ +2 148  44 💤 +1  0 ❌  - 1 

Results for commit 73c99f6. ± Comparison against base commit b78dfc3.

♻️ This comment has been updated with latest results.

@Artur- Artur- changed the title fix: JRebel support for Vaadin 24 fix: Restore JRebel support May 9, 2023
@Artur-
Artur- marked this pull request as ready for review May 9, 2023 11:06
@Artur-
Artur- requested a review from jcgueriaud1 May 9, 2023 11:06

@jcgueriaud1 jcgueriaud1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still a deprecated class? since it's useful at least for JRebel.

@Artur-

Artur- commented May 9, 2023

Copy link
Copy Markdown
Member Author

There is no other use for it. Also JRebel should move to use BrowserLiveReloadAccessor

@Artur-
Artur- enabled auto-merge (squash) May 9, 2023 11:13
@Artur-
Artur- disabled auto-merge May 9, 2023 11:13
@Artur-
Artur- enabled auto-merge (squash) May 9, 2023 11:13
@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels May 9, 2023
@sonarqubecloud

sonarqubecloud Bot commented May 9, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Artur-
Artur- merged commit 1917577 into main May 9, 2023
@Artur-
Artur- deleted the jrebel branch May 9, 2023 11:24
vaadin-bot pushed a commit that referenced this pull request May 9, 2023
JRebel detects `BrowserLiveReloadAccess` and uses it to trigger the browser reload
Artur- pushed a commit that referenced this pull request May 9, 2023
JRebel detects `BrowserLiveReloadAccess` and uses it to trigger the browser reload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants