Skip to content

Fix homebrew try-with-resources to behave like it is supposed to. (#16776) (CP: 24.0) - #16805

Merged
vaadin-bot merged 1 commit into
24.0from
cherry-pick-16776-to-24.0-1684314947473
May 17, 2023
Merged

vaadin-bot merged 1 commit into
24.0from
cherry-pick-16776-to-24.0-1684314947473

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

If an exception is thrown, and then another exception is thrown when trying to close() the stream, the exception that gets propagated to the outside world is the bogus/meaningless close() exception, not the actual root cause exception. This makes debugging much harder because the root cause exception is being completely lost.
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
vaadin-bot enabled auto-merge (squash) May 17, 2023 09:26
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   949 files  ±0     949 suites  ±0   1h 6m 22s ⏱️ + 1m 36s
6 021 tests +1  5 985 ✔️ +1  36 💤 ±0  0 ❌ ±0 
6 276 runs  +5  6 233 ✔️ +3  43 💤 +2  0 ❌ ±0 

Results for commit 82822f8. ± Comparison against base commit 62effbc.

@vaadin-bot
vaadin-bot merged commit 518285a into 24.0 May 17, 2023
@vaadin-bot
vaadin-bot deleted the cherry-pick-16776-to-24.0-1684314947473 branch May 17, 2023 09:43
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 24.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants