Skip to content

fix: support silent updates for tsconfig.json from Hilla 2.0 - #17010

Merged
platosha merged 4 commits into
mainfrom
fix/ap/hilla-nodenext-tsconfig
Jun 14, 2023
Merged

platosha merged 4 commits into
mainfrom
fix/ap/hilla-nodenext-tsconfig

Conversation

@platosha

Copy link
Copy Markdown
Contributor

Fixes vaadin/hilla#960

For some time between 2.0 and 2.1 version releases Hilla starters had "moduleResolution": "nodeNext" in the default tsconfig.json, while still using the same version key.

This change enables silent updates from those to the latest tsconfig.json.

@github-actions

github-actions Bot commented Jun 13, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   994 files  ±0     994 suites  ±0   1h 3m 23s ⏱️ + 3m 48s
6 313 tests ±0  6 272 ✔️ ±0  41 💤 ±0  0 ❌ ±0 
6 566 runs   - 1  6 518 ✔️  - 1  48 💤 ±0  0 ❌ ±0 

Results for commit a30bd3c. ± Comparison against base commit 66d87d5.

♻️ This comment has been updated with latest results.

Fixes vaadin/hilla#960

For some time between 2.0 and 2.1 version releases Hilla starters had
`"moduleResolution": "nodeNext"` in the default `tsconfig.json`, while
still using the same version key.

This change enables silent updates from those to the latest `tsconfig.json`.
@platosha
platosha force-pushed the fix/ap/hilla-nodenext-tsconfig branch from 0ce3422 to 45edebc Compare June 13, 2023 12:40
@platosha
platosha requested a review from taefi June 14, 2023 07:37
@mshabarov mshabarov added the hilla Issues related to Hilla label Jun 14, 2023
@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Jun 14, 2023
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@platosha
platosha requested a review from Lodin June 14, 2023 09:51
@platosha
platosha enabled auto-merge (squash) June 14, 2023 09:51
@Lodin
Lodin self-requested a review June 14, 2023 09:52
@platosha
platosha merged commit 8bb1e01 into main Jun 14, 2023
@platosha
platosha deleted the fix/ap/hilla-nodenext-tsconfig branch June 14, 2023 10:00
vaadin-bot pushed a commit that referenced this pull request Jun 14, 2023
Fixes vaadin/hilla#960

For some time between 2.0 and 2.1 version releases Hilla starters had
`"moduleResolution": "nodeNext"` in the default `tsconfig.json`, while
still using the same version key.

This change enables silent updates from those to the latest `tsconfig.json`.
@taefi
taefi removed their request for review June 14, 2023 10:04
vaadin-bot added a commit that referenced this pull request Jun 14, 2023
…#17022)

Fixes vaadin/hilla#960

For some time between 2.0 and 2.1 version releases Hilla starters had
`"moduleResolution": "nodeNext"` in the default `tsconfig.json`, while
still using the same version key.

This change enables silent updates from those to the latest `tsconfig.json`.

Co-authored-by: Anton Platonov <anton@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PiT 24.1: when upgrading a hilla-react app from 2.0 to 2.1 the first time it fails

4 participants