Skip to content

fix: do not have server sources in client - #17045

Merged
mshabarov merged 4 commits into
mainfrom
issues/17020-server-sources-as-resource
Jun 19, 2023
Merged

mshabarov merged 4 commits into
mainfrom
issues/17020-server-sources-as-resource

Conversation

@caalador

Copy link
Copy Markdown
Contributor

add flow-server sources as
a sources dependency instead
of a src resource.

Closes #17020

@caalador

Copy link
Copy Markdown
Contributor Author

Running with Eclipse
Version: 2023-06 (4.28.0)
Build id: 20230608-1333

I couldn't see any issues with having the sources as a dependency.

@github-actions

github-actions Bot commented Jun 16, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   995 files  +   198     995 suites  +198   1h 0m 42s ⏱️ + 10m 46s
6 323 tests +2 154  6 282 ✔️ +2 154  41 💤 +1  0 ❌  - 1 
6 582 runs  +2 168  6 534 ✔️ +2 168  48 💤 +1  0 ❌  - 1 

Results for commit be5c69b. ± Comparison against base commit 97e4844.

♻️ This comment has been updated with latest results.

add flow-server sources as
a sources dependency instead
of a src resource.

Closes #17020
@caalador
caalador force-pushed the issues/17020-server-sources-as-resource branch from 96488eb to e6bdcfb Compare June 16, 2023 09:13
@mcollovati

Copy link
Copy Markdown
Collaborator

Tested with IDEA, and it works fine, no need to exclude flow-client project anymore 👍

Also tested with Eclipse

Version: 2023-03 (4.27.0)
Build id: 20230309-1520

It took a while to import the project and I had to do run Maven -> Update project a couple of times before having the IDE not complaining about errors.
Based on my memories of working with Eclipse on maven multimodule projects, the slowness and the need for multiple "Update project" is somehow expected.

@mvysny

mvysny commented Jun 19, 2023

Copy link
Copy Markdown
Member

This is awesome, thank you so much! This will improve the developer experience and lower the barrier of contributing to Flow 👍

@caalador

Copy link
Copy Markdown
Contributor Author

Also tested with NetBeans IDE 17 without any issues (guess 18 will not have issues either)

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mshabarov
mshabarov merged commit b99eddc into main Jun 19, 2023
@mshabarov
mshabarov deleted the issues/17020-server-sources-as-resource branch June 19, 2023 11:36
vaadin-bot pushed a commit that referenced this pull request Jun 19, 2023
add flow-server sources as
a sources dependency instead
of a src resource.

Closes #17020
vaadin-bot added a commit that referenced this pull request Jun 19, 2023
add flow-server sources as
a sources dependency instead
of a src resource.

Closes #17020

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flow-client-sources.jar contains source files from flow-server.jar

5 participants