Repository navigation
fix: Only write Vite config files when they have changed - #17433
Merged
Merged
Conversation
Prevents Vite from restarting when not needed Fixes vaadin/hilla#1134
Member
Author
|
The problem is clearly seen in Hilla+React projects as any Java change results in followed by |
Member
Author
|
This has not been a problem in earlier version as there was a bug in Vite preventing it from correctly watching all its config files for changes. Now that Vite works, it is an issue |
Contributor
caalador
reviewed
Aug 14, 2023
caalador
approved these changes
Aug 14, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Artur-
enabled auto-merge (squash)
August 14, 2023 10:13
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
Prevents Vite from restarting when not needed Fixes vaadin/hilla#1134
vaadin-bot
added a commit
that referenced
this pull request
Aug 14, 2023
…7437) Prevents Vite from restarting when not needed Fixes vaadin/hilla#1134 Co-authored-by: Artur <artur@vaadin.com>
Collaborator
|
This ticket/PR has been released with Vaadin 24.2.0.alpha7 and is also targeting the upcoming stable 24.2.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Prevents Vite from restarting when not needed
Fixes vaadin/hilla#1134