Skip to content

fix: updated missing theme notice - #17482

Merged
MarcinVaadin merged 2 commits into
mainfrom
fix/theme-editor-link
Aug 23, 2023
Merged

MarcinVaadin merged 2 commits into
mainfrom
fix/theme-editor-link

Conversation

@MarcinVaadin

Copy link
Copy Markdown
Contributor

Description

As in title

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

szolo
szolo previously approved these changes Aug 22, 2023

@szolo szolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 looks good

@MarcinVaadin
MarcinVaadin enabled auto-merge (squash) August 22, 2023 14:27
@github-actions

github-actions Bot commented Aug 22, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

1 002 files  ±0  1 002 suites  ±0   1h 3m 55s ⏱️ - 1m 49s
6 390 tests ±0  6 349 ✔️ ±0  41 💤 ±0  0 ❌ ±0 
6 646 runs   - 1  6 598 ✔️  - 1  48 💤 ±0  0 ❌ ±0 

Results for commit f7c3f7d. ± Comparison against base commit 349945a.

♻️ This comment has been updated with latest results.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MarcinVaadin
MarcinVaadin requested a review from szolo August 23, 2023 05:42

@szolo szolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcinVaadin IT test update approved 👍

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha8 and is also targeting the upcoming stable 24.2.0 version.

vaadin-bot pushed a commit that referenced this pull request Sep 26, 2023
vaadin-bot added a commit that referenced this pull request Sep 26, 2023
Co-authored-by: marcin <marcin@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants