Repository navigation
fix: handle shadow DOM stylesheets in production and dev bundle - #17776
Merged
Merged
Conversation
The legacy shadow DOM stylesheets that can potentially be present in the 'theme/<themeName>/components/' folder are not considered when deciding if a new bundle needs to be created, so the application may miss custom components styles. This change checks for existence of theme components CSS, and it triggers a bundle rebuild if any is found. Fixes #16407
Contributor
Collaborator
Author
|
Picking to 24.2 should fail because of the newly added test module; the parent pom version must be manually fixed on the backport. |
mshabarov
reviewed
Oct 6, 2023
mshabarov
approved these changes
Oct 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
enabled auto-merge (squash)
October 6, 2023 13:00
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
* fix: handle shadow DOM stylesheets in production and dev bundle The legacy shadow DOM stylesheets that can potentially be present in the 'theme/<themeName>/components/' folder are not considered when deciding if a new bundle needs to be created, so the application may miss custom components styles. This change checks for existence of theme components CSS, and it triggers a bundle rebuild if any is found. Fixes #16407 * apply review suggestions * apply review suggestions
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
* fix: handle shadow DOM stylesheets in production and dev bundle The legacy shadow DOM stylesheets that can potentially be present in the 'theme/<themeName>/components/' folder are not considered when deciding if a new bundle needs to be created, so the application may miss custom components styles. This change checks for existence of theme components CSS, and it triggers a bundle rebuild if any is found. Fixes #16407 * apply review suggestions * apply review suggestions
vaadin-bot
added a commit
that referenced
this pull request
Oct 6, 2023
…) (CP: 24.1) (#17798) * fix: handle shadow DOM stylesheets in production and dev bundle (#17776) * fix: handle shadow DOM stylesheets in production and dev bundle The legacy shadow DOM stylesheets that can potentially be present in the 'theme/<themeName>/components/' folder are not considered when deciding if a new bundle needs to be created, so the application may miss custom components styles. This change checks for existence of theme components CSS, and it triggers a bundle rebuild if any is found. Fixes #16407 * apply review suggestions * apply review suggestions * fixed parent pom version --------- Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Oct 6, 2023
…) (CP: 24.2) (#17797) * fix: handle shadow DOM stylesheets in production and dev bundle (#17776) * fix: handle shadow DOM stylesheets in production and dev bundle The legacy shadow DOM stylesheets that can potentially be present in the 'theme/<themeName>/components/' folder are not considered when deciding if a new bundle needs to be created, so the application may miss custom components styles. This change checks for existence of theme components CSS, and it triggers a bundle rebuild if any is found. Fixes #16407 * apply review suggestions * apply review suggestions * fixed parent pom version --------- Co-authored-by: Marco Collovati <marco@vaadin.com>
Collaborator
|
This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The legacy shadow DOM stylesheets that can potentially be present in the 'theme//components/' folder are not considered when deciding if a new bundle needs to be created, so the application may miss custom components styles.
This change checks for the existence of theme components CSS, and it triggers a bundle rebuild if any are found.
Fixes #16407
Type of change
Checklist
Additional for
Featuretype of change