Skip to content

fix: reroute to NotFoundException from default RouteAccessDeniedError - #18084

Merged
mcollovati merged 2 commits into
mainfrom
fix/reroute-from-default-access-denied-error
Nov 21, 2023
Merged

mcollovati merged 2 commits into
mainfrom
fix/reroute-from-default-access-denied-error

Conversation

@tltv

@tltv tltv commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

This makes AccessDeniedException's default error page to work by default just like in the previous versions before AccessDeniedException even when NotFoundException is customized.

Fixes: #18082

This makes `AccessDeniedException`'s default error page to work by default just like in the previous versions before `AccessDeniedException` even when `NotFoundException` is customized.

Fixes: #18082
@github-actions

github-actions Bot commented Nov 21, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

1 041 files  ±0  1 041 suites  ±0   1h 13m 45s ⏱️ -47s
6 696 tests ±0  6 651 ✔️ ±0  45 💤 ±0  0 ❌ ±0 
6 993 runs  ±0  6 937 ✔️ ±0  56 💤 ±0  0 ❌ ±0 

Results for commit 20f5b1c. ± Comparison against base commit 6ad5b49.

♻️ This comment has been updated with latest results.

@tltv

tltv commented Nov 21, 2023

Copy link
Copy Markdown
Contributor Author

There's another issue with route path access checker that need to be fixed first before this can work.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tltv tltv assigned mcollovati and unassigned mcollovati Nov 21, 2023
@tltv
tltv requested review from mcollovati and mshabarov November 21, 2023 14:22
@mcollovati
mcollovati merged commit 524f148 into main Nov 21, 2023
@mcollovati
mcollovati deleted the fix/reroute-from-default-access-denied-error branch November 21, 2023 14:53
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.alpha6 and is also targeting the upcoming stable 24.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PIT] mention the RouteAccessDeniedError introduced in V24.3 release note

3 participants