Repository navigation
fix: handle inner classes in component tracker - #18348
Merged
Merged
Conversation
ComponentTracker location fails to determine the source file for inner classes. This change tries to identify the enclosing class before matching with location filename. Fixes #18216
Contributor
tltv
suggested changes
Dec 28, 2023
mcollovati
commented
Dec 28, 2023
tltv
approved these changes
Dec 28, 2023
|
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 28, 2023
ComponentTracker location fails to determine the source file for inner classes. This change tries to identify the enclosing class before matching with location filename. Fixes #18216
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 28, 2023
ComponentTracker location fails to determine the source file for inner classes. This change tries to identify the enclosing class before matching with location filename. Fixes #18216
vaadin-bot
added a commit
that referenced
this pull request
Dec 28, 2023
ComponentTracker location fails to determine the source file for inner classes. This change tries to identify the enclosing class before matching with location filename. Fixes #18216 Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Dec 28, 2023
ComponentTracker location fails to determine the source file for inner classes. This change tries to identify the enclosing class before matching with location filename. Fixes #18216 Co-authored-by: Marco Collovati <marco@vaadin.com>
Collaborator
|
This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
ComponentTracker location fails to determine the source file for inner classes. This change tries to identify the enclosing class before matching with location filename.
Fixes #18216
Type of change
Checklist
Additional for
Featuretype of change