Skip to content

fix: handle inner classes in component tracker - #18348

Merged
mcollovati merged 3 commits into
mainfrom
issues/18216_componenttracker_innerclass
Dec 28, 2023
Merged

mcollovati merged 3 commits into
mainfrom
issues/18216_componenttracker_innerclass

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

Description

ComponentTracker location fails to determine the source file for inner classes. This change tries to identify the enclosing class before matching with location filename.

Fixes #18216

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

ComponentTracker location fails to determine the source file for inner classes.
This change tries to identify the enclosing class before matching with location
filename.

Fixes #18216
@github-actions

github-actions Bot commented Dec 21, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

1 050 files  + 1  1 050 suites  +1   1h 17m 29s ⏱️ + 3m 39s
6 767 tests + 5  6 722 ✅ + 5  45 💤 ±0  0 ❌ ±0 
7 074 runs  +16  7 018 ✅ +16  56 💤 ±0  0 ❌ ±0 

Results for commit ae0cb26. ± Comparison against base commit fa40d0a.

♻️ This comment has been updated with latest results.

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Dec 28, 2023
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Dec 28, 2023
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcollovati
mcollovati merged commit df47c83 into main Dec 28, 2023
@mcollovati
mcollovati deleted the issues/18216_componenttracker_innerclass branch December 28, 2023 14:18
vaadin-bot pushed a commit that referenced this pull request Dec 28, 2023
ComponentTracker location fails to determine the source file for inner classes.
This change tries to identify the enclosing class before matching with location
filename.

Fixes #18216
vaadin-bot pushed a commit that referenced this pull request Dec 28, 2023
ComponentTracker location fails to determine the source file for inner classes.
This change tries to identify the enclosing class before matching with location
filename.

Fixes #18216
vaadin-bot added a commit that referenced this pull request Dec 28, 2023
ComponentTracker location fails to determine the source file for inner classes.
This change tries to identify the enclosing class before matching with location
filename.

Fixes #18216

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Dec 28, 2023
ComponentTracker location fails to determine the source file for inner classes.
This change tries to identify the enclosing class before matching with location
filename.

Fixes #18216

Co-authored-by: Marco Collovati <marco@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

[Component Tracker]Cannot open a component inside an inner class

3 participants