Repository navigation
fix: change SBOM maven goals lifecycle phase - #18550
Conversation
Test Results1 092 files ±0 1 092 suites ±0 1h 21m 45s ⏱️ + 1m 23s Results for commit 3b62c9a. ± Comparison against base commit b8a992a. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
With the latest changes, |
As far as I know, that option is only used here. We could just remove the Your call. |
|
Ok, I'll double-check it. I don't think we're using Options class from any other project either. |
|
We also have this interesting snippet here: |
3b94cfa to
42ec4da
Compare
|
| .withJarFrontendResourcesFolder( | ||
| getJarFrontendResourcesFolder(adapter)) | ||
| .createMissingPackageJson( | ||
| new File(adapter.npmFolder(), PACKAGE_JSON).exists()) |
There was a problem hiding this comment.
I think this was an incorrect leftover in some old bugfix.
Setting true here looks safe to me.
mshabarov
left a comment
There was a problem hiding this comment.
Looks reasonable to me to not run SBOM generate goal earlier than prepare-frontend goal, as the latter prepares needed frontend meta data for SBOM.
|
This ticket/PR has been released with Vaadin 24.4.0.alpha4 and is also targeting the upcoming stable 24.4.0 version. |

Description
generate-resourcestoprepare-resourcesso that it matches theprepare-frontendmaven goal.package.jsonfile is created if it doesn't exist when running theprepare-frontendmaven goal.