Repository navigation
feat: add utility to auto-detect Hilla views usage - #18602
Merged
Merged
Conversation
Adds `FrontendUtils.isHillaViewsUsed(File frontendDir)` to check if Hilla views are used in routes.ts or routes.tsx file. This does the check based on these two files only and the `routes` array variable content without doing any validation. Hilla views are in use in following cases based on the `routes` array: - If file does not contain `...serversideRoutes` - If `routes` contains anything else in addition to `...serversideRoutes` - If tsx has `...serversideRoutes` in MainLayout's `children` array Hilla views are not used in following case: - If `...serversideRoutes` is the only item
Contributor
mshabarov
requested changes
Feb 2, 2024
|
mshabarov
approved these changes
Feb 5, 2024
mshabarov
left a comment
Contributor
There was a problem hiding this comment.
Tested with the following configurations:
- plain Flow app
- hybrid Hilla + Flow + React app
- Hilla + React app
- hybrid Hilla + Flow + Lit
In all cases return expected resolution.
Collaborator
|
This ticket/PR has been released with Vaadin 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version. |
rodolforfq
pushed a commit
that referenced
this pull request
Feb 8, 2024
* feat: add utility to auto-detect Hilla views usage Adds `FrontendUtils.isHillaViewsUsed(File frontendDir)` to check if Hilla views are used in routes.ts or routes.tsx file. This does the check based on these two files only and the `routes` array variable content without doing any validation. Hilla views are in use in following cases based on the `routes` array: - If file does not contain `...serversideRoutes` - If `routes` contains anything else in addition to `...serversideRoutes` - If tsx has `...serversideRoutes` in MainLayout's `children` array Hilla views are not used in following case: - If `...serversideRoutes` is the only item * chore: changes by code review findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds
FrontendUtils.isHillaViewsUsed(File frontendDir)to check if Hilla views are used in routes.ts or routes.tsx file. This does the check based on these two files only and theroutesarray variable content without doing any validation.Hilla views are in use in following cases based on the
routesarray:...serversideRoutesroutescontains anything else in addition to...serversideRoutes...serversideRoutesin MainLayout'schildrenarrayHilla views are not used in following case:
...serversideRoutesis the only itemRelated-to: #18577