Skip to content

feat: enable frontend fallback - #18828

Merged
mshabarov merged 24 commits into
mainfrom
issues/18436-fallback-to-legacy
Feb 29, 2024
Merged

mshabarov merged 24 commits into
mainfrom
issues/18436-fallback-to-legacy

Conversation

@caalador

Copy link
Copy Markdown
Contributor

Enable falling back to the
original frontend folder if
the new one doesn't exist.

@github-actions

github-actions Bot commented Feb 28, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 095 files  + 54  1 095 suites  +54   1h 18m 18s ⏱️ + 6m 24s
6 939 tests +337  6 890 ✅ +336  49 💤 +1  0 ❌ ±0 
7 262 runs  +324  7 201 ✅ +323  61 💤 +1  0 ❌ ±0 

Results for commit daf54de. ± Comparison against base commit 69b1d4f.

♻️ This comment has been updated with latest results.

@caalador
caalador force-pushed the issues/18436-fallback-to-legacy branch 2 times, most recently from 8a2fc22 to 7d91458 Compare February 29, 2024 08:09
Enable falling back to the
original frontend folder if
the new one doesn't exist.

gradle generated should depend on frontendDir

Fix generated to follow frontend
@caalador
caalador force-pushed the issues/18436-fallback-to-legacy branch from 7d91458 to b7881a7 Compare February 29, 2024 08:48
@mshabarov

mshabarov commented Feb 29, 2024 •

Copy link
Copy Markdown
Contributor

Something is missing, as now if I move the frontend folder into src/main by hand, and start the app:

  • when running with IDE's play button, the frontend location resolved well and I get app started and running.
    - when I run with mvn, Flow looks into ./frontend still and explodes because theme is missing in ./frontend

@mshabarov

Copy link
Copy Markdown
Contributor

It was my mistake, I haven't changed the plugin from vaadin-maven-plugin to flow-maven-plugin and only built the Flow.
So after corrections, I got the following configurations working well with starter project:

  1. Legacy folder in root
  2. Folder in src/main
  3. Custom location "./my-frontend" and parameter <frontendDirectory>./my-frontend</frontendDirectory>.

I think we can merge it.

@mshabarov
mshabarov enabled auto-merge (squash) February 29, 2024 14:45
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshabarov
mshabarov merged commit bb25955 into main Feb 29, 2024
@mshabarov
mshabarov deleted the issues/18436-fallback-to-legacy branch February 29, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants