Skip to content

fix: detect Flow PUSH requests as internal framework requests - #19085

Merged
tepi merged 1 commit into
mainfrom
issues/19075_push_frameowrk_request
Apr 4, 2024
Merged

tepi merged 1 commit into
mainfrom
issues/19075_push_frameowrk_request

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

Description

HandlerHelper is currently not considering Flow PUSH requests (/VAADIN/push) as internal, preventing VaadinWebSecurity to ignore CSRF checks.
The issues happen only for ping requests; the connection request is not affected because it is a GET request.

Fixes #19075

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

HandlerHelper is currently not considering Flow PUSH requests
(/VAADIN/push) as internal, preventing VaadinWebSecurity to
ignore CSRF checks.
The issues happen only for ping requests; the connection request
is not affected because it is a GET request.

Fixes #19075
@sonarqubecloud

sonarqubecloud Bot commented Apr 3, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions

github-actions Bot commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Test Results

1 091 files  ± 0  1 091 suites  ±0   1h 23m 26s ⏱️ - 2m 42s
6 939 tests + 2  6 890 ✅ + 2  49 💤 ±0  0 ❌ ±0 
7 291 runs  +38  7 230 ✅ +38  61 💤 ±0  0 ❌ ±0 

Results for commit 06f4b1d. ± Comparison against base commit cc01569.

@mshabarov
mshabarov requested a review from tepi April 3, 2024 10:06
@tepi
tepi merged commit 4459d6b into main Apr 4, 2024
@tepi
tepi deleted the issues/19075_push_frameowrk_request branch April 4, 2024 12:02
vaadin-bot pushed a commit that referenced this pull request Apr 4, 2024
HandlerHelper is currently not considering Flow PUSH requests
(/VAADIN/push) as internal, preventing VaadinWebSecurity to
ignore CSRF checks.
The issues happen only for ping requests; the connection request
is not affected because it is a GET request.

Fixes #19075
vaadin-bot added a commit that referenced this pull request Apr 4, 2024
#19110)

HandlerHelper is currently not considering Flow PUSH requests
(/VAADIN/push) as internal, preventing VaadinWebSecurity to
ignore CSRF checks.
The issues happen only for ping requests; the connection request
is not affected because it is a GET request.

Fixes #19075

Co-authored-by: Marco Collovati <marco@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha21 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

VaadinWebSecurity does not ignore CSRF for Flow PUSH connection request

3 participants