Skip to content

fix: allow css properties in react components (#19077) - #19170

Merged
mshabarov merged 5 commits into
mainfrom
fix/allow-inline-css-properties
Apr 19, 2024
Merged

mshabarov merged 5 commits into
mainfrom
fix/allow-inline-css-properties

Conversation

@tepi

@tepi tepi commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

Fixes #19077

@github-actions

github-actions Bot commented Apr 15, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 095 files  ±0  1 095 suites  ±0   1h 23m 38s ⏱️ + 4m 26s
6 949 tests +4  6 900 ✅ +4  49 💤 ±0  0 ❌ ±0 
7 283 runs  +7  7 222 ✅ +7  61 💤 ±0  0 ❌ ±0 

Results for commit 9c0ba3d. ± Comparison against base commit 5b6b0ca.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.
com.vaadin.flow.server.frontend.TaskGenerateTsDefinitionsTest ‑ customTsDefinition_oldFlowContents_tsDefinitionUpdatedAndWarningLogged
com.vaadin.flow.server.frontend.TaskGenerateTsDefinitionsTest ‑ customTsDefinition_v1FlowContents_tsDefinitionUpdatedAndWarningLogged
com.vaadin.flow.server.frontend.TaskGenerateTsDefinitionsTest ‑ customTsDefinition_v2FlowContents_tsDefinitionUpdatedAndWarningLogged
com.vaadin.flow.server.frontend.TaskGenerateTsDefinitionsTest ‑ tsDefinition_oldHillaV2Contents_ignoringMultilineComments_tsDefinitionUpdated
com.vaadin.flow.server.frontend.TaskGenerateTsDefinitionsTest ‑ tsDefinition_oldHillaV2Contents_ignoringSingleLineComments_tsDefinitionUpdated
com.vaadin.flow.server.frontend.TaskGenerateTsDefinitionsTest ‑ tsDefinition_oldHillaV2Contents_tsDefinitionUpdated

♻️ This comment has been updated with latest results.

@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Apr 15, 2024
@mshabarov
mshabarov self-requested a review April 16, 2024 11:04
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Apr 19, 2024
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Apr 19, 2024
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshabarov
mshabarov enabled auto-merge (squash) April 19, 2024 12:33
@mshabarov
mshabarov disabled auto-merge April 19, 2024 12:33
@mshabarov
mshabarov enabled auto-merge (squash) April 19, 2024 12:34
@mshabarov
mshabarov merged commit 3cfb744 into main Apr 19, 2024
@mshabarov
mshabarov deleted the fix/allow-inline-css-properties branch April 19, 2024 12:40
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha24 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using css properties in inline styles in React components should not trigger TypeScript errors

3 participants