Skip to content

fix: include system classpath elements when collecting - #19175

Merged
mcollovati merged 6 commits into
mainfrom
fix/support-maven-system-scope
May 7, 2024
Merged

mcollovati merged 6 commits into
mainfrom
fix/support-maven-system-scope

Conversation

@cromoteca

@cromoteca cromoteca commented Apr 15, 2024 •

Copy link
Copy Markdown
Contributor

Adds system dependencies to classpath collection so that vaadin/hilla#2328 can work.

@github-actions

github-actions Bot commented Apr 15, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 101 files  ±0  1 101 suites  ±0   1h 22m 29s ⏱️ -33s
7 004 tests ±0  6 955 ✅ ±0  49 💤 ±0  0 ❌ ±0 
7 376 runs   - 2  7 315 ✅  - 2  61 💤 ±0  0 ❌ ±0 

Results for commit 2447354. ± Comparison against base commit fe30566.

♻️ This comment has been updated with latest results.

@mshabarov
mshabarov requested a review from mcollovati April 16, 2024 11:03
@cromoteca
cromoteca marked this pull request as ready for review April 26, 2024 13:23

@mcollovati mcollovati left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delay. I did not notice that my comment was still pending

mcollovati
mcollovati previously approved these changes Apr 29, 2024
@mcollovati
mcollovati self-requested a review May 6, 2024 13:09
@mcollovati
mcollovati dismissed their stale review May 6, 2024 13:09

Needs additional discussion

@mcollovati
mcollovati enabled auto-merge (squash) May 7, 2024 14:16
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants