Skip to content

fix: prevent embedded styles to leak main document (#19221) (CP: 23.5) - #19242

Merged
tltv merged 2 commits into
23.5from
cherry/cherrypick-19221-to-23.5
Apr 25, 2024
Merged

tltv merged 2 commits into
23.5from
cherry/cherrypick-19221-to-23.5

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

When using an exported a themed Flow web-component, Lumo style may leak the embedding document, causing invalid CSS rules to be applied. This change prevents applying Lumo global imports when the theme is applied to a web-component.

Fixes #12704

When using an exported a themed Flow web-component, Lumo style may leak
the embedding document, causing invalid CSS rules to be applied.
This change prevents applying Lumo global imports when the theme is
applied to a web-component.

Fixes #12704
@github-actions

github-actions Bot commented Apr 24, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

  960 files  ±0    960 suites  ±0   45m 9s ⏱️ +15s
6 285 tests +3  6 236 ✅ +3  49 💤 ±0  0 ❌ ±0 
6 550 runs  +6  6 493 ✅ +6  57 💤 ±0  0 ❌ ±0 

Results for commit 3253259. ± Comparison against base commit c8154de.

♻️ This comment has been updated with latest results.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tltv
tltv merged commit 1a7635d into 23.5 Apr 25, 2024
@tltv
tltv deleted the cherry/cherrypick-19221-to-23.5 branch April 25, 2024 07:25
ZheSun88 pushed a commit that referenced this pull request Apr 25, 2024
When using an exported a themed Flow web-component, Lumo style may leak
the embedding document, causing invalid CSS rules to be applied.
This change prevents applying Lumo global imports when the theme is
applied to a web-component.

Fixes #12704
ZheSun88 pushed a commit that referenced this pull request Apr 25, 2024
When using an exported a themed Flow web-component, Lumo style may leak
the embedding document, causing invalid CSS rules to be applied.
This change prevents applying Lumo global imports when the theme is
applied to a web-component.

Fixes #12704
vaadin-bot added a commit that referenced this pull request Apr 25, 2024
When using an exported a themed Flow web-component, Lumo style may leak
the embedding document, causing invalid CSS rules to be applied.
This change prevents applying Lumo global imports when the theme is
applied to a web-component.

Fixes #12704

Co-authored-by: Marco Collovati <marco@vaadin.com>
mshabarov pushed a commit that referenced this pull request Apr 26, 2024
When using an exported a themed Flow web-component, Lumo style may leak
the embedding document, causing invalid CSS rules to be applied.
This change prevents applying Lumo global imports when the theme is
applied to a web-component.

Fixes #12704

Co-authored-by: Marco Collovati <marco@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants