Skip to content

fix: Generate flow imports in the same folder - #19254

Merged
caalador merged 5 commits into
mainfrom
place-wc-import-into-same-folder
Apr 26, 2024
Merged

caalador merged 5 commits into
mainfrom
place-wc-import-into-same-folder

Conversation

@mshabarov

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Apr 25, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 099 files  + 21  1 099 suites  +21   1h 23m 31s ⏱️ + 12m 43s
6 999 tests + 83  6 949 ✅ + 82  50 💤 +1  0 ❌ ±0 
7 376 runs  +103  7 314 ✅ +102  62 💤 +1  0 ❌ ±0 

Results for commit 24256b6. ± Comparison against base commit ff10370.

♻️ This comment has been updated with latest results.

@mshabarov
mshabarov marked this pull request as ready for review April 25, 2024 12:51
@mcollovati

Copy link
Copy Markdown
Collaborator

Just a note: since #19037 has been merged, handling of the webcomponent imports file could be added in TaskRemoveOldFrontendGeneratedFiles.isKnownUnhandledFile

caalador
caalador previously approved these changes Apr 26, 2024
@mshabarov

Copy link
Copy Markdown
Contributor Author

Just a note: since #19037 has been merged, handling of the webcomponent imports file could be added in TaskRemoveOldFrontendGeneratedFiles.isKnownUnhandledFile

Added to isKnownUnhandledFile.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@caalador
caalador merged commit 04355c1 into main Apr 26, 2024
@caalador
caalador deleted the place-wc-import-into-same-folder branch April 26, 2024 09:26
mshabarov added a commit that referenced this pull request Apr 26, 2024
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @mshabarov and @caalador, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 04355c1
error: could not apply 04355c1... fix: Generate flow imports in the same folder (#19254)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha25 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants