Repository navigation
fix: require the minimum interface needed - #19571
Merged
Merged
Conversation
Only require AbstractConfiguration in the MenuRegistry as that has the required information.
tltv
suggested changes
Jun 13, 2024
Contributor
mcollovati
reviewed
Jun 13, 2024
mcollovati
left a comment
Collaborator
There was a problem hiding this comment.
Apart from the comment of Tomi, LGTM
…stry.java Co-authored-by: Tomi Virtanen <tltv@vaadin.com>
tltv
approved these changes
Jun 13, 2024
caalador
enabled auto-merge (squash)
June 13, 2024 07:23
|
Collaborator
|
This ticket/PR has been released with Vaadin 24.5.0.alpha3 and is also targeting the upcoming stable 24.5.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Only require AbstractConfiguration
in the MenuRegistry as that has
the required information.