Skip to content

fix: require the minimum interface needed - #19571

Merged
caalador merged 2 commits into
mainfrom
fix/require-only-abstractconfiguration
Jun 13, 2024
Merged

caalador merged 2 commits into
mainfrom
fix/require-only-abstractconfiguration

Conversation

@caalador

Copy link
Copy Markdown
Contributor

Only require AbstractConfiguration
in the MenuRegistry as that has
the required information.

Only require AbstractConfiguration
in the MenuRegistry as that has
the required information.
@caalador
caalador requested a review from mcollovati June 13, 2024 07:13
caalador added a commit to vaadin/hilla that referenced this pull request Jun 13, 2024
@github-actions

github-actions Bot commented Jun 13, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 124 files  ± 0  1 124 suites  ±0   1h 20m 53s ⏱️ -32s
7 263 tests ± 0  7 214 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 581 runs   - 21  7 522 ✅  - 21  59 💤 ±0  0 ❌ ±0 

Results for commit 7efc114. ± Comparison against base commit d0c6b5b.

♻️ This comment has been updated with latest results.

@mcollovati mcollovati left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment of Tomi, LGTM

…stry.java

Co-authored-by: Tomi Virtanen <tltv@vaadin.com>
@caalador
caalador enabled auto-merge (squash) June 13, 2024 07:23
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@caalador
caalador merged commit 5832c83 into main Jun 13, 2024
@caalador
caalador deleted the fix/require-only-abstractconfiguration branch June 13, 2024 07:35
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha3 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants