Skip to content

fix: Validate layout values - #19873

Merged
caalador merged 2 commits into
mainfrom
fix/check-duplicate-layout-values
Sep 4, 2024
Merged

caalador merged 2 commits into
mainfrom
fix/check-duplicate-layout-values

Conversation

@caalador

@caalador caalador commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

Check Layout annotations
for duplicate values.
If found throw exception.

Fixes #19872

Check Layout annotations
for duplicate values.
If found throw exception.

Fixes #19872
@github-actions

github-actions Bot commented Sep 3, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 135 files  ±0  1 135 suites  ±0   1h 27m 50s ⏱️ + 1m 48s
7 385 tests +1  7 335 ✅ +1  50 💤 ±0  0 ❌ ±0 
7 702 runs   - 8  7 642 ✅  - 8  60 💤 ±0  0 ❌ ±0 

Results for commit 856d74e. ± Comparison against base commit d5a4013.

♻️ This comment has been updated with latest results.

@tepi

tepi commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

LGTM otherwise, but should the duplicates-not-allowed also be mentioned in Layout javadoc? At least I could not see it there.

@caalador

caalador commented Sep 4, 2024

Copy link
Copy Markdown
Contributor Author

LGTM otherwise, but should the duplicates-not-allowed also be mentioned in Layout javadoc? At least I could not see it there.

Yes should be noted in the documentation. Basically you can have duplicates but only one will be then used which would lead to confusion on the layout chosen.

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Sep 4, 2024
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2024

Copy link
Copy Markdown

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha15 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Having multiple Layout with same value should throw

4 participants