Repository navigation
fix: Validate layout values - #19873
Merged
Merged
Conversation
Check Layout annotations for duplicate values. If found throw exception. Fixes #19872
Contributor
Contributor
|
LGTM otherwise, but should the duplicates-not-allowed also be mentioned in |
mcollovati
requested changes
Sep 3, 2024
Clen up code
Contributor
Author
Yes should be noted in the documentation. Basically you can have duplicates but only one will be then used which would lead to confusion on the layout chosen. |
|
mcollovati
approved these changes
Sep 4, 2024
Collaborator
|
This ticket/PR has been released with Vaadin 24.5.0.alpha15 and is also targeting the upcoming stable 24.5.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Check Layout annotations
for duplicate values.
If found throw exception.
Fixes #19872