Skip to content

fix: No react module for Vaadin Router - #19878

Merged
mshabarov merged 3 commits into
mainfrom
issues/19870-vaadin-router-from-index
Sep 4, 2024
Merged

mshabarov merged 3 commits into
mainfrom
issues/19870-vaadin-router-from-index

Conversation

@caalador

@caalador caalador commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

Remove reactOutlet module
if we are not running react,
but are using Vaadin Router
inferred from index.ts

Fixes #19870

Remove reactOutlet module
if we are not running react,
but are using Vaadin Router
inferred from index.ts

Fixes #19870
@github-actions

github-actions Bot commented Sep 3, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 135 files  +  820  1 135 suites  +820   1h 29m 48s ⏱️ + 26m 31s
7 386 tests +6 581  7 336 ✅ +6 551  50 💤 +30  0 ❌ ±0 
7 738 runs  +6 841  7 681 ✅ +6 804  57 💤 +37  0 ❌ ±0 

Results for commit 5a92a83. ± Comparison against base commit b00b97c.

♻️ This comment has been updated with latest results.

mcollovati
mcollovati previously approved these changes Sep 3, 2024

@mcollovati mcollovati left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the project mentioned in the linked issue and with the fix, both running in development mode and building the production artifact work fine.

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Sep 4, 2024
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Sep 4, 2024
@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2024

Copy link
Copy Markdown

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha15 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PiT 24.5: routing fails making impossible to run a downloaded hybrid application from start

4 participants