Skip to content

fix: safely handle nested removal of menu routes - #19885

Merged
caalador merged 3 commits into
mainfrom
fix/nested-menu-route-removal
Sep 4, 2024
Merged

caalador merged 3 commits into
mainfrom
fix/nested-menu-route-removal

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

MenuRegistry.filterClientViews removes inaccessible routes and their child routes from the menu items. When iterating the list of all routes, a NPE can occur if a child route has already been removed together with its parent route. This adds a check that prevents the NPE.

@github-actions

github-actions Bot commented Sep 4, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 135 files  ± 0  1 135 suites  ±0   1h 28m 38s ⏱️ +27s
7 386 tests + 1  7 336 ✅ + 1  50 💤 ±0  0 ❌ ±0 
7 689 runs   - 58  7 629 ✅  - 58  60 💤 ±0  0 ❌ ±0 

Results for commit 4ba0f6f. ± Comparison against base commit 818d284.

♻️ This comment has been updated with latest results.

@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2024

Copy link
Copy Markdown

@mcollovati mcollovati added the Contribution PRs coming from the community or external to the team label Sep 4, 2024
@mshabarov
mshabarov requested a review from caalador September 4, 2024 06:01
@caalador
caalador merged commit c120a07 into main Sep 4, 2024
@caalador
caalador deleted the fix/nested-menu-route-removal branch September 4, 2024 06:31
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha15 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants