Skip to content

fix: ensure session is registered with Hotswapper - #19979

Merged
mcollovati merged 2 commits into
mainfrom
issues/19973_hotswapper_register_existing_sessions
Sep 19, 2024
Merged

mcollovati merged 2 commits into
mainfrom
issues/19973_hotswapper_register_existing_sessions

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

Description

VaadinSession references are registered in Hotswapper in a session init listener. However, the listener might not always been invoked, for example if the HTTP session is serialized and deserialized on server restart. This change registers a UI init listener to make sure VaadinSession reference is also registered for existing sessions.

Fixes #19973

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

VaadinSession references are registered in Hotswapper in a session init
listener. However, the listener might not always been invoked, for example
if the HTTP session is serialized and deserialized on server restart.
This change registers a UI init listener to make sure VaadinSession reference
is also registered for existing sessions.

Fixes #19973
@github-actions

github-actions Bot commented Sep 18, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 137 files  ± 0  1 137 suites  ±0   1h 9m 58s ⏱️ - 11m 35s
7 399 tests ± 0  7 349 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 759 runs  +39  7 699 ✅ +39  60 💤 ±0  0 ❌ ±0 

Results for commit adbfe54. ± Comparison against base commit bf420c4.

♻️ This comment has been updated with latest results.

@vaadin-bot vaadin-bot added +0.1.0 and removed +1.0.0 labels Sep 19, 2024
@sonarqubecloud

Copy link
Copy Markdown

@mcollovati
mcollovati merged commit e7ac185 into main Sep 19, 2024
@mcollovati
mcollovati deleted the issues/19973_hotswapper_register_existing_sessions branch September 19, 2024 11:52
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Hotswapper is unaware of stored sessions

3 participants