Skip to content

feat: Report application URL when application is started - #20027

Merged
mcollovati merged 4 commits into
mainfrom
report-app-url
Sep 24, 2024
Merged

mcollovati merged 4 commits into
mainfrom
report-app-url

Conversation

@Artur-

@Artur- Artur- commented Sep 23, 2024

Copy link
Copy Markdown
Member

This is useful in a couple of cases:

  1. Browser launcher is not enabled
  2. Browser launcher does not work
  3. You closed the browser tab and a new one is not automatically reopened when you restart

This is useful in a couple of cases:
1. Browser launcher is not enabled
2. Browser launcher does not work
3. You closed the browser tab and a new one is not automatically reopened when you restart
@github-actions

github-actions Bot commented Sep 23, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 137 files  ± 0  1 137 suites  ±0   1h 11m 21s ⏱️ +51s
7 399 tests ± 0  7 349 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 734 runs   - 27  7 674 ✅  - 28  60 💤 +1  0 ❌ ±0 

Results for commit 578a221. ± Comparison against base commit 396d1c5.

♻️ This comment has been updated with latest results.

@mcollovati

mcollovati commented Sep 23, 2024 •

Copy link
Copy Markdown
Collaborator

Browser launcher is not enabled

If I set vaadin.launch-browser=false or do not add the entry at all in application.properties, the URL is not printed

@Artur-

Artur- commented Sep 23, 2024

Copy link
Copy Markdown
Member Author

True, Spring never reports the URL to the dev server if the launch setting is off. Fixed now

@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Sep 23, 2024
@mcollovati
mcollovati enabled auto-merge (squash) September 24, 2024 07:03
@sonarqubecloud

Copy link
Copy Markdown

@mcollovati
mcollovati merged commit 622f05b into main Sep 24, 2024
@mcollovati
mcollovati deleted the report-app-url branch September 24, 2024 07:16
vaadin-bot pushed a commit that referenced this pull request Sep 24, 2024
This is useful in a couple of cases:
1. Browser launcher is not enabled
2. Browser launcher does not work
3. You closed the browser tab and a new one is not automatically reopened when you restart
mshabarov pushed a commit that referenced this pull request Sep 24, 2024
…0037)

This is useful in a couple of cases:
1. Browser launcher is not enabled
2. Browser launcher does not work
3. You closed the browser tab and a new one is not automatically reopened when you restart

Co-authored-by: Artur <artur@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants