Skip to content

fix: Store layout packages - #20075

Merged
mshabarov merged 1 commit into
mainfrom
issues/20066-spring-dev-reload
Sep 27, 2024
Merged

mshabarov merged 1 commit into
mainfrom
issues/20066-spring-dev-reload

Conversation

@caalador

Copy link
Copy Markdown
Contributor

Store layout packages
in development mode reload
cache as layouts may not be
in same packages as routes.

Fixes #20066

Store layout packages
in development mode reload
cache as layouts may not be
in same packages as routes.

Fixes #20066
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

1 137 files  ±0  1 137 suites  ±0   1h 8m 56s ⏱️ - 1m 2s
7 399 tests ±0  7 349 ✅ ±0  50 💤 ±0  0 ❌ ±0 
7 740 runs   - 3  7 680 ✅  - 6  60 💤 +3  0 ❌ ±0 

Results for commit cb5a04f. ± Comparison against base commit 4844adb.

@mshabarov mshabarov left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected with this patch, LGTM.

To note: to reproduce this issue one should place route class to a separate folder/package, if the route and layout are in the same package, this problem does not show up.

Two questions to think about:

  • how can this be covered by tests
  • how we can prevent similar issues in the future, when we are adding new routing annotations?

@mshabarov

Copy link
Copy Markdown
Contributor

Let discuss these question on Monday and meanwhile let me make another beta release.

@mshabarov
mshabarov merged commit d493508 into main Sep 27, 2024
@mshabarov
mshabarov deleted the issues/20066-spring-dev-reload branch September 27, 2024 13:06
vaadin-bot pushed a commit that referenced this pull request Sep 27, 2024
Store layout packages
in development mode reload
cache as layouts may not be
in same packages as routes.

Fixes #20066
vaadin-bot added a commit that referenced this pull request Sep 27, 2024
Store layout packages
in development mode reload
cache as layouts may not be
in same packages as routes.

Fixes #20066

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@Layout is lost on view change

3 participants