Skip to content

fix: add nodeVersion in gradle plugin settings (#20059) (CP: 24.5) - #20089

Merged
vaadin-bot merged 1 commit into
24.5from
cherry-pick-20059-to-24.5-1727444022015
Sep 30, 2024
Merged

vaadin-bot merged 1 commit into
24.5from
cherry-pick-20059-to-24.5-1727444022015

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

Prior to this fix, the settings declared in Gradle were not being passed to the plugin. For example, changing the nodeVersion in build.gradle did not update the actual nodeVersion used.
@github-actions

github-actions Bot commented Sep 27, 2024 •

Copy link
Copy Markdown
Contributor

Test Results

1 137 files  +  232  1 137 suites  +232   1h 11m 19s ⏱️ + 13m 44s
7 400 tests +2 533  7 350 ✅ +2 533  50 💤 +1  0 ❌  - 1 
7 767 runs  +2 550  7 707 ✅ +2 550  60 💤 +1  0 ❌  - 1 

Results for commit df9c15b. ± Comparison against base commit 59bf5c5.

♻️ This comment has been updated with latest results.

@sonarqubecloud

Copy link
Copy Markdown

@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
vaadin-bot enabled auto-merge (squash) September 27, 2024 14:28
@vaadin-bot
vaadin-bot merged commit 06c7707 into 24.5 Sep 30, 2024
@vaadin-bot
vaadin-bot deleted the cherry-pick-20059-to-24.5-1727444022015 branch September 30, 2024 06:10
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 24.5.0.beta4 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants