Skip to content

fix: import parent theme lumoImports in dev bundle mode (#20325) (CP: main) - #20380

Merged
mshabarov merged 1 commit into
mainfrom
cherry-pick-20325-to-main-1730207731458
Oct 30, 2024
Merged

mshabarov merged 1 commit into
mainfrom
cherry-pick-20325-to-main-1730207731458

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

* fix: import parent theme lumoImports in dev bundle mode

Adds missing css imports for parent theme when given in parent theme.json with lumoImports property and running with dev bundle.

Fixes: #19567

* test: fix test

* test: fix test

* chore: catch IllegalArgumentException in CssBundler

Catch and debug log IllegalArgumentException possibly thrown from potentialFile.toPath() in Windows. Url's in css like 'https://fonts.googleapis.com/css?family=Itim' shouldn't be considered as copyable asset files.
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

1 142 files  ± 0  1 142 suites  ±0   1h 24m 52s ⏱️ +28s
7 477 tests + 2  7 427 ✅ + 3  50 💤 ±0  0 ❌ ±0 
7 842 runs  +26  7 782 ✅ +27  60 💤 ±0  0 ❌ ±0 

Results for commit dfe5fe4. ± Comparison against base commit 0e70cb1.

@sonarqubecloud

Copy link
Copy Markdown

@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants