Skip to content

fix: remove modal component on route refresh (#20540) (CP: 24.5) - #20583

Merged
vaadin-bot merged 1 commit into
24.5from
cherry-pick-20540-to-24.5-1732878198189
Nov 29, 2024
Merged

vaadin-bot merged 1 commit into
24.5from
cherry-pick-20540-to-24.5-1732878198189

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

Modal components attached to the UI were not removed or replaced during
self-navigation triggered by a route refresh.
This change updates navigation handler to ensure modal components are
removed and adds a new navigation trigger for route refresh to differentiate
programmatic navigations (e.g., forward actions).
It also modifies Hotswapper to require a full chain refresh when modal
components are present.

Fixes #20473
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
vaadin-bot enabled auto-merge (squash) November 29, 2024 11:12
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

1 147 files  ±0  1 147 suites  ±0   1h 26m 8s ⏱️ + 3m 46s
7 484 tests +3  7 434 ✅ +3  50 💤 ±0  0 ❌ ±0 
7 835 runs  +5  7 775 ✅ +5  60 💤 ±0  0 ❌ ±0 

Results for commit 58c7f24. ± Comparison against base commit bb5626d.

@vaadin-bot
vaadin-bot merged commit 4b7ea7d into 24.5 Nov 29, 2024
@vaadin-bot
vaadin-bot deleted the cherry-pick-20540-to-24.5-1732878198189 branch November 29, 2024 11:24
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 24.5.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants