Skip to content

fix: prevent generated pwa icons to be added to manifest (#20639) (CP: 24.6) - #20650

Merged
vaadin-bot merged 1 commit into
24.6from
cherry-pick-20639-to-24.6-1733747899018
Dec 9, 2024
Merged

vaadin-bot merged 1 commit into
24.6from
cherry-pick-20639-to-24.6-1733747899018

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

Generated PWA icons are served at runtime by PwaHandler, that also takes care
of adding a subset of them to the web manifest for caching.
However, the Vite inject-manifest-to-sw plugin adds all generated icons to the
manifest with /pwa-icons path prefix making them pre-cached by the browser and
potentially breaking pre-defined security rules.
This change prevents generated icons to be added to the manifest, preserving
the previous behavior.
@sonarqubecloud

sonarqubecloud Bot commented Dec 9, 2024

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

Test Results

1 158 files  ±0  1 158 suites  ±0   1h 29m 27s ⏱️ - 4m 14s
7 518 tests ±0  7 465 ✅ ±0  53 💤 ±0  0 ❌ ±0 
7 843 runs   - 9  7 783 ✅  - 9  60 💤 ±0  0 ❌ ±0 

Results for commit e9b5a9f. ± Comparison against base commit 7fb42bb.

@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
vaadin-bot merged commit 420f7c9 into 24.6 Dec 9, 2024
@vaadin-bot
vaadin-bot deleted the cherry-pick-20639-to-24.6-1733747899018 branch December 9, 2024 13:30
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 24.6.0.rc1 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants