Skip to content

fix: set page height to 100% instead of 100vh - #21025

Merged
mshabarov merged 3 commits into
mainfrom
set-page-height-to-100%
Mar 13, 2025
Merged

mshabarov merged 3 commits into
mainfrom
set-page-height-to-100%

Conversation

@vursen

@vursen vursen commented Feb 21, 2025 •

Copy link
Copy Markdown
Contributor

Description

The PR modifies the page height from 100vh to 100% to prevent the content area from extending underneath the navbar on mobile devices:

- body, #outlet {
+ html, body, #outlet {
-   height: 100vh;
+   height: 100%;
    width: 100%;
    margin: 0;
  }
height: 100vh height: 100%
Image Image

Fixes #21024

Type of change

  • Bugfix

@github-actions

github-actions Bot commented Feb 21, 2025 •

Copy link
Copy Markdown
Contributor

Test Results

1 170 files  ±0  1 170 suites  ±0   1h 15m 37s ⏱️ + 1m 20s
7 785 tests ±0  7 728 ✅ ±0  57 💤 ±0  0 ❌ ±0 
8 145 runs   - 5  8 079 ✅  - 5  66 💤 ±0  0 ❌ ±0 

Results for commit 985d67a. ± Comparison against base commit 4f29383.

♻️ This comment has been updated with latest results.

@vursen
vursen marked this pull request as ready for review March 12, 2025 11:48
@vursen
vursen requested review from mshabarov and web-padawan March 13, 2025 07:34
@mshabarov
mshabarov enabled auto-merge (squash) March 13, 2025 11:55
@sonarqubecloud

Copy link
Copy Markdown

@mshabarov
mshabarov merged commit d6af1c8 into main Mar 13, 2025
@mshabarov
mshabarov deleted the set-page-height-to-100% branch March 13, 2025 12:09
vaadin-bot pushed a commit that referenced this pull request Mar 13, 2025
The PR modifies the page height from 100vh to 100% to prevent the content area from extending underneath the navbar on mobile devices:

- body, #outlet {
+ html, body, #outlet {
-   height: 100vh;
+   height: 100%;
    width: 100%;
    margin: 0;
  }
vaadin-bot added a commit that referenced this pull request Mar 14, 2025
The PR modifies the page height from 100vh to 100% to prevent the content area from extending underneath the navbar on mobile devices:

- body, #outlet {
+ html, body, #outlet {
-   height: 100vh;
+   height: 100%;
    width: 100%;
    margin: 0;
  }

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.8.0.alpha2 and is also targeting the upcoming stable 24.8.0 version.

@knoobie

knoobie commented May 24, 2025 •

Copy link
Copy Markdown
Contributor

@mshabarov Now there are some other things that has to be aligned as well. The documentation has wrong defaults as well as @bodysize

https://vaadin.com/docs/latest/flow/advanced/modifying-the-bootstrap-page

https://vaadin.com/api/platform/current/com/vaadin/flow/component/page/BodySize.html

Context: https://vaadin.com/forum/t/set-vertical-layout-to-stretch-to-whole-screen/177997/11

Edit: all starters that use the old index.html have to be updated as well for example https://github.com/vaadin/base-starter-gradle/blob/v24/src/main/frontend/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content area extends under navbar on iOS due to page height 100vh

5 participants