Skip to content

fix: Use handlers registered using ResourceHandlerRegistry (#21686) (CP: 24.8) - #21712

Merged
mcollovati merged 5 commits into
24.8from
use-registry-handlers-24.8
Jun 18, 2025
Merged

mcollovati merged 5 commits into
24.8from
use-registry-handlers-24.8

Conversation

@Artur-

@Artur- Artur- commented Jun 17, 2025

Copy link
Copy Markdown
Member

For instance Swagger uses ResourceHandlerRegistry to register a handler for /swagger-ui/index.html and this is now called without excluding any url from Vaadin

Artur- added 2 commits June 17, 2025 14:33
For instance Swagger uses ResourceHandlerRegistry to register a handler for /swagger-ui/index.html and this is now called without excluding any url from Vaadin
@Artur-
Artur- marked this pull request as ready for review June 17, 2025 11:44
@mcollovati

Copy link
Copy Markdown
Collaborator

We can probably make the diff label 0.0.1 by adding a deprecated public RootExcludeHandler vaadinRootMapping(Environment environment) method, but maybe it is not worth it.

@github-actions

github-actions Bot commented Jun 17, 2025 •

Copy link
Copy Markdown
Contributor

Test Results

1 235 files  ± 0  1 235 suites  ±0   1h 11m 57s ⏱️ - 1m 15s
8 546 tests ± 0  8 490 ✅ ± 0  56 💤 ±0  0 ❌ ±0 
8 922 runs   - 24  8 857 ✅  - 24  65 💤 ±0  0 ❌ ±0 

Results for commit 340db2a. ± Comparison against base commit aacd2f4.

♻️ This comment has been updated with latest results.

@Artur-

Artur- commented Jun 18, 2025

Copy link
Copy Markdown
Member Author

Isn't the correct "fix" to remove all "public" modifiers from @Bean declarator methods?

@mcollovati

mcollovati commented Jun 18, 2025 •

Copy link
Copy Markdown
Collaborator

Isn't the correct "fix" to remove all "public" modifiers from @Bean declarator methods?

Yes, that would be the best option.
But it could be considered a breaking change. Perhaps we can refactor all bean definitions in 25 an make all of them package private.

@mcollovati

Copy link
Copy Markdown
Collaborator

We agreed on adding the deprecated method. I'll update the PR and then merge it.

@sonarqubecloud

Copy link
Copy Markdown

@vaadin-bot vaadin-bot added +0.1.0 and removed +1.0.0 labels Jun 18, 2025
@mcollovati
mcollovati enabled auto-merge (squash) June 18, 2025 09:52
@mcollovati
mcollovati merged commit 42b93d8 into 24.8 Jun 18, 2025
@mcollovati
mcollovati deleted the use-registry-handlers-24.8 branch June 18, 2025 09:53
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants