Repository navigation
fix: Fail on multiple executors only when the executor is accessed - #21839
Conversation
|
Test Results1 232 files ±0 1 232 suites ±0 1h 14m 31s ⏱️ + 1m 5s Results for commit fd22883. ± Comparison against base commit b053557. This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both. |
|
From what I see, this approach bypasses the possibility of bypassing conflicting Spring beans through As an alternative approach, we could maybe create a placeholder executor instance where |
Did not get this. Then the throw block in
That can be an option, but in that case the stack trace may be less readable and also you spot this when a signal will try to execute something at runtime. I'd prefer an exception during initialisation. |
If that's the case, then I do indeed prefer this approach excactly because of the clearer stacktraces. I was for some reason assuming the logic in |
|
My statement was based on this.executor = event.getExecutor()
.orElseGet(this::createDefaultExecutor);in So Vaadin either uses the one from |
…21839) (#21843) Does not fail eagerly if a Spring app has multiple TaskExecutor bean (without VaadinTaskExecutor qualifier). Instead it fails when an app tries to access VaadinService.getExecutor() directly or via using a feature that uses this executor (currently the signals preview). Fixes #21811 Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
…21839) (#21844) Does not fail eagerly if a Spring app has multiple TaskExecutor bean (without VaadinTaskExecutor qualifier). Instead it fails when an app tries to access VaadinService.getExecutor() directly or via using a feature that uses this executor (currently the signals preview). Fixes #21811 Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>



Does not fail eagerly if a Spring app has multiple
TaskExecutorbean (withoutVaadinTaskExecutorqualifier).Instead it fails when an app tries to access
VaadinService.getExecutor()directly or via using a feature that uses this executor (currently the signals preview).Fixes #21811