Skip to content

fix!: remove construct-style-sheets-polyfill - #21977

Merged
tltv merged 2 commits into
mainfrom
fix/remove-construct-style-sheets-polyfill
Aug 5, 2025
Merged

tltv merged 2 commits into
mainfrom
fix/remove-construct-style-sheets-polyfill

Conversation

@tltv

@tltv tltv commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

construct-style-sheets-polyfill dependency is no longer needed since supported browsers for Vaadin 25 don't need it.

Fixes: #21675

construct-style-sheets-polyfill dependency is no longer needed since supported browsers for Vaadin 25 don't need it.

Fixes: #21675
@github-actions

github-actions Bot commented Aug 1, 2025 •

Copy link
Copy Markdown
Contributor

Test Results

1 237 files  ± 0  1 237 suites  ±0   1h 13m 58s ⏱️ + 1m 18s
8 497 tests ± 0  8 437 ✅ ± 0  60 💤 ±0  0 ❌ ±0 
8 899 runs  +14  8 830 ✅ +14  69 💤 ±0  0 ❌ ±0 

Results for commit e207012. ± Comparison against base commit 9fba12b.

♻️ This comment has been updated with latest results.

@tltv
tltv marked this pull request as ready for review August 1, 2025 12:05
@mshabarov

Copy link
Copy Markdown
Contributor

Should we mark this as a breaking change for old browser versions?

@tltv

tltv commented Aug 4, 2025

Copy link
Copy Markdown
Contributor Author

Should we mark this as a breaking change for old browser versions?

Probably yes, it's a braking change since polyfill is still required with Safari 15...16.3.

@tltv tltv changed the title fix: remove construct-style-sheets-polyfill fix!: remove construct-style-sheets-polyfill Aug 4, 2025
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2025

Copy link
Copy Markdown

@tltv
tltv merged commit 319ed79 into main Aug 5, 2025
@tltv
tltv deleted the fix/remove-construct-style-sheets-polyfill branch August 5, 2025 12:42
Copilot AI pushed a commit that referenced this pull request Oct 1, 2025
construct-style-sheets-polyfill dependency is no longer needed since supported browsers for Vaadin 25 don't need it.

Fixes: #21675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "construct-style-sheets-polyfill" in Vaadin 25

3 participants