Skip to content

fix: Component styles feature flag not working in Gradle projects - #22104

Merged
mshabarov merged 2 commits into
mainfrom
gradle-component-theme
Sep 1, 2025
Merged

mshabarov merged 2 commits into
mainfrom
gradle-component-theme

Conversation

@Artur-

@Artur- Artur- commented Aug 26, 2025

Copy link
Copy Markdown
Member

The theme component styles feature flag (com.vaadin.experimental.themeComponentStyles) was not working in Gradle projects due to the theme plugin incorrectly parsing the path to find the vaadin-featureflags.properties file.

The fix adds an explicit javaResourceFolder path to the theme options, allowing the theme plugin to directly locate the feature flags file instead of trying to parse it from the projectStaticOutput path, which has different structures in Maven and Gradle projects.

Fixes #22073

…2073)

The theme component styles feature flag (com.vaadin.experimental.themeComponentStyles)
was not working in Gradle projects due to the theme plugin incorrectly parsing
the path to find the vaadin-featureflags.properties file.

The fix adds an explicit javaResourceFolder path to the theme options, allowing
the theme plugin to directly locate the feature flags file instead of trying
to parse it from the projectStaticOutput path, which has different structures
in Maven and Gradle projects.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 26, 2025 •

Copy link
Copy Markdown
Contributor

Test Results

1 246 files  ±0  1 246 suites  ±0   1h 15m 30s ⏱️ + 1m 43s
8 630 tests ±0  8 563 ✅ ±0  67 💤 ±0  0 ❌ ±0 
9 042 runs   - 7  8 965 ✅  - 6  77 💤  - 1  0 ❌ ±0 

Results for commit 1ebb96b. ± Comparison against base commit c80f04c.

♻️ This comment has been updated with latest results.

@mshabarov
mshabarov requested a review from caalador August 26, 2025 15:59
@caalador

Copy link
Copy Markdown
Contributor

The other choice would ofc be to just give the actual feature flag value directly from Java code into the settings file.

@mshabarov
mshabarov merged commit a7fbebc into main Sep 1, 2025
@mshabarov
mshabarov deleted the gradle-component-theme branch September 1, 2025 11:42
Copilot AI pushed a commit that referenced this pull request Oct 1, 2025
…2104)

* fix: Component styles feature flag not working in Gradle projects (#22073)

The theme component styles feature flag (com.vaadin.experimental.themeComponentStyles)
was not working in Gradle projects due to the theme plugin incorrectly parsing
the path to find the vaadin-featureflags.properties file.

The fix adds an explicit javaResourceFolder path to the theme options, allowing
the theme plugin to directly locate the feature flags file instead of trying
to parse it from the projectStaticOutput path, which has different structures
in Maven and Gradle projects.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* format

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature flag for component styles doesn't work in Gradle projects

4 participants