Repository navigation
fix: Component styles feature flag not working in Gradle projects - #22104
Merged
Merged
Conversation
…2073) The theme component styles feature flag (com.vaadin.experimental.themeComponentStyles) was not working in Gradle projects due to the theme plugin incorrectly parsing the path to find the vaadin-featureflags.properties file. The fix adds an explicit javaResourceFolder path to the theme options, allowing the theme plugin to directly locate the feature flags file instead of trying to parse it from the projectStaticOutput path, which has different structures in Maven and Gradle projects. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Contributor
caalador
approved these changes
Aug 27, 2025
Contributor
|
The other choice would ofc be to just give the actual feature flag value directly from Java code into the settings file. |
Copilot AI
pushed a commit
that referenced
this pull request
Oct 1, 2025
…2104) * fix: Component styles feature flag not working in Gradle projects (#22073) The theme component styles feature flag (com.vaadin.experimental.themeComponentStyles) was not working in Gradle projects due to the theme plugin incorrectly parsing the path to find the vaadin-featureflags.properties file. The fix adds an explicit javaResourceFolder path to the theme options, allowing the theme plugin to directly locate the feature flags file instead of trying to parse it from the projectStaticOutput path, which has different structures in Maven and Gradle projects. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * format --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The theme component styles feature flag (com.vaadin.experimental.themeComponentStyles) was not working in Gradle projects due to the theme plugin incorrectly parsing the path to find the vaadin-featureflags.properties file.
The fix adds an explicit javaResourceFolder path to the theme options, allowing the theme plugin to directly locate the feature flags file instead of trying to parse it from the projectStaticOutput path, which has different structures in Maven and Gradle projects.
Fixes #22073