Skip to content

fix: create missing directory before writing dev bundle README - #22309

Merged
caalador merged 4 commits into
mainfrom
dev-bundle-readme
Sep 23, 2025
Merged

caalador merged 4 commits into
mainfrom
dev-bundle-readme

Conversation

@Artur-

@Artur- Artur- commented Sep 22, 2025 •

Copy link
Copy Markdown
Member
  • Fix IOException by ensuring src/main/bundles directory exists before creating README file
  • Add mkdirs() call to create the directory if it doesn't exist
  • Refactor: Extract getDevBundleFolderInTarget() and getDevBundleFolderInSrc() methods
    to clearly distinguish between target (build output) and src (version control) locations
  • Remove unused README_NOT_CREATED field and improve error messages with actual file paths

Fixes #22306

- Fix IOException by ensuring src/main/bundles directory exists before creating README file
- Add mkdirs() call to create the directory if it doesn't exist
- Refactor: Extract getDevBundleFolderInTarget() and getDevBundleFolderInSrc() methods
  to clearly distinguish between target (build output) and src (version control) locations
- Remove unused README_NOT_CREATED field and improve error messages with actual file paths

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@Artur- Artur- changed the title fix: correct dev bundle README path and refactor duplicated code (#22306) fix: create missing directory before writing dev bundle README Sep 22, 2025
@Artur-
Artur- requested a review from caalador September 22, 2025 11:09
@Artur-
Artur- marked this pull request as ready for review September 22, 2025 11:09
@Artur-

Artur- commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

Not sure if this is correct or if it is just supposed to write the readme into target and it's supposed to be copied later?

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

1 265 files  +113  1 265 suites  +113   1h 14m 50s ⏱️ + 12m 11s
8 641 tests +274  8 574 ✅ +263  67 💤 +11  0 ❌ ±0 
9 110 runs  +290  9 032 ✅ +278  78 💤 +12  0 ❌ ±0 

Results for commit 173c8bb. ± Comparison against base commit 724bb86.

@caalador

Copy link
Copy Markdown
Contributor

The idea is that if we generate a .bundle file in the src bundles then we would add the readme so that it would be clear what this folder and files are all about.
So the change seems fine as it for some reason didn't fail after moving the compression to a later time so we get the assets also in the bundle archives.

@caalador
caalador merged commit 3f1315f into main Sep 23, 2025
@caalador
caalador deleted the dev-bundle-readme branch September 23, 2025 03:57
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @Artur- and @caalador, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 3f1315f
error: could not apply 3f1315f... fix: create missing directory before writing dev bundle README (#22309)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

caalador pushed a commit that referenced this pull request Sep 23, 2025
ensure src/main/bundles directory exists before
creating README file
mcollovati pushed a commit that referenced this pull request Sep 23, 2025
… (#22316)

ensure src/main/bundles directory exists before
creating README file

Co-authored-by: Artur <artur@vaadin.com>
Copilot AI pushed a commit that referenced this pull request Oct 1, 2025
ensure src/main/bundles directory exists before
creating README file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IOException: No such file or directory when building a dev bundle

4 participants