Skip to content

fix: ensure to add feature-flags import at the start of bundle (#22329) (CP: 24.9) - #22340

Merged
vaadin-bot merged 1 commit into
24.9from
cherry-pick-22329-to-24.9-1758703034540
Sep 24, 2025
Merged

vaadin-bot merged 1 commit into
24.9from
cherry-pick-22329-to-24.9-1758703034540

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

The feature flags import in dev mode with the hot reload disabled ends
up after the custom elements definition. This is problematic for cases,
like the `layoutComponentsImprovements`, where the feature flag value is
checked at the definition time to decide whether some CSS styles should
be added or not.

This change moves the appending of the feature flags import to the end
of the method, and adds it at the start of the file.

Fixes #vaadin/web-component#9571
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

1 261 files  ± 0  1 261 suites  ±0   1h 12m 56s ⏱️ +6s
8 655 tests + 1  8 593 ✅ + 1  62 💤 ±0  0 ❌ ±0 
9 031 runs  +19  8 960 ✅ +17  71 💤 +2  0 ❌ ±0 

Results for commit ab2e248. ± Comparison against base commit 8ff6b80.

@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
vaadin-bot enabled auto-merge (squash) September 24, 2025 08:54
@sonarqubecloud

Copy link
Copy Markdown

@vaadin-bot
vaadin-bot merged commit 968d30c into 24.9 Sep 24, 2025
@vaadin-bot
vaadin-bot deleted the cherry-pick-22329-to-24.9-1758703034540 branch September 24, 2025 09:07
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 24.9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants