Repository navigation
fix: ensure to add feature-flags import at the start of bundle (#22329) (CP: 24.9) - #22340
Merged
Merged
Conversation
The feature flags import in dev mode with the hot reload disabled ends up after the custom elements definition. This is problematic for cases, like the `layoutComponentsImprovements`, where the feature flag value is checked at the definition time to decide whether some CSS styles should be added or not. This change moves the appending of the feature flags import to the end of the method, and adds it at the start of the file. Fixes #vaadin/web-component#9571
Contributor
vaadin-review-bot
approved these changes
Sep 24, 2025
Collaborator
Author
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot] |
vaadin-bot
enabled auto-merge (squash)
September 24, 2025 08:54
|
Collaborator
Author
|
This ticket/PR has been released with Vaadin 24.9.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.