Skip to content

fix: authentication redirect to login - #22354

Merged
caalador merged 2 commits into
mainfrom
issues/22280-redirect-to-login
Sep 29, 2025
Merged

caalador merged 2 commits into
mainfrom
issues/22280-redirect-to-login

Conversation

@caalador

Copy link
Copy Markdown
Contributor

Fixes redirect to login when
authenticated, but getting
accessDenied.

Fixes #22280

Fixes redirect to login when
authenticated, but getting
accessDenied.

Fixes #22280
@github-actions

github-actions Bot commented Sep 26, 2025 •

Copy link
Copy Markdown
Contributor

Test Results

1 265 files  ±0  1 265 suites  ±0   1h 18m 3s ⏱️ +11s
8 645 tests +1  8 578 ✅ +1  67 💤 ±0  0 ❌ ±0 
9 110 runs   - 4  9 033 ✅  - 4  77 💤 ±0  0 ❌ ±0 

Results for commit 6c9bcbe. ± Comparison against base commit 7af239d.

♻️ This comment has been updated with latest results.

@tltv tltv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but how about tests? Is there any even in Hilla?

@caalador

Copy link
Copy Markdown
Contributor Author

I'll try to think about the possibility of tests, but as the issue comes up in a hilla react project I'm not certain what we can test for this in flow.

@tltv

tltv commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

I'll try to think about the possibility of tests, but as the issue comes up in a hilla react project I'm not certain what we can test for this in flow.

IT would be ideal but just unit test in VaadinSecurityConfigurerTest for hilla endpoint specific configuration could be helpful later.

@caalador
caalador requested a review from tltv September 29, 2025 07:40
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Sep 29, 2025
@sonarqubecloud

Copy link
Copy Markdown

@caalador
caalador merged commit b0f7666 into main Sep 29, 2025
@caalador
caalador deleted the issues/22280-redirect-to-login branch September 29, 2025 08:08
caalador added a commit that referenced this pull request Sep 30, 2025
Artur- pushed a commit that referenced this pull request Sep 30, 2025
Copilot AI pushed a commit that referenced this pull request Oct 1, 2025
Fixes redirect to login when
authenticated, but getting
accessDenied.

Fixes #22280
Copilot AI pushed a commit that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No redirect to /login if a user's role has no privileges

3 participants