Skip to content

chore!: Set minimum Node version to 24 - #22419

Merged
Artur- merged 4 commits into
mainfrom
require-node24
Oct 6, 2025
Merged

Artur- merged 4 commits into
mainfrom
require-node24

Conversation

@Artur-

@Artur- Artur- commented Oct 3, 2025

Copy link
Copy Markdown
Member

Node 24 becomes the active LTS before 25.0.0 - guaranteeing the longest possible support

Artur- added 2 commits October 3, 2025 19:11
Node 24 becomes the active LTS before 25.0.0 - guaranteeing the longest possible support
@Artur-
Artur- requested a review from mshabarov October 3, 2025 16:12
@github-actions

github-actions Bot commented Oct 3, 2025 •

Copy link
Copy Markdown
Contributor

Test Results

1 268 files  ± 0  1 268 suites  ±0   1h 14m 14s ⏱️ -46s
8 713 tests ± 0  8 646 ✅ ± 0  67 💤 ±0  0 ❌ ±0 
9 168 runs  +28  9 090 ✅ +27  78 💤 +1  0 ❌ ±0 

Results for commit a9780d9. ± Comparison against base commit 016b794.

♻️ This comment has been updated with latest results.

@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Oct 6, 2025
@mshabarov

Copy link
Copy Markdown
Contributor

Maybe change to Node.js 22 instead ? 22 is maintained until Apr 2027 and IMO it's weird to have same major versions for default and minimal supported.

@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2025

Copy link
Copy Markdown

@Artur-

Artur- commented Oct 6, 2025

Copy link
Copy Markdown
Member Author

What would be the benefit of staying on 22?

@mshabarov

Copy link
Copy Markdown
Contributor

Not being able to upgrade to 24 immediately for this or that reason. But we would hopefully see if this turn into a problem for someone.

@Artur-
Artur- merged commit 29df465 into main Oct 6, 2025
8 checks passed
@Artur-
Artur- deleted the require-node24 branch October 6, 2025 07:42
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-beta2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants