Skip to content

fix: Set required Java and Maven versions in flow-maven-plugin (23.7) - #23436

Merged
caalador merged 1 commit into
23.7from
fix/set-required-java-version-for-maven-plugin-23.7
Feb 10, 2026
Merged

caalador merged 1 commit into
23.7from
fix/set-required-java-version-for-maven-plugin-23.7

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

Prevents potential issues with Maven versions >= 3.9.12 if a Java version newer than the supported one is used to package the Maven plugin.

@github-actions

github-actions Bot commented Feb 9, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

  985 files  ±0    985 suites  ±0   40m 27s ⏱️ -20s
6 340 tests ±0  6 290 ✅ ±0  50 💤 ±0  0 ❌ ±0 
6 659 runs  +3  6 601 ✅ +3  58 💤 ±0  0 ❌ ±0 

Results for commit 66cb3c2. ± Comparison against base commit bd0b3a6.

♻️ This comment has been updated with latest results.

@caalador caalador left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the package lock change actually needed for the plugin update?

@mcollovati

Copy link
Copy Markdown
Collaborator Author

is the package lock change actually needed for the plugin update?

Nope. Pushed by mistake. Thanks for noticing!

Prevents potential issues with Maven versions >= 3.9.12
if a Java version newer than the supported one is used
to package the Maven plugin.
@mcollovati
mcollovati force-pushed the fix/set-required-java-version-for-maven-plugin-23.7 branch from 2e0adbb to 66cb3c2 Compare February 10, 2026 08:16
@mcollovati

Copy link
Copy Markdown
Collaborator Author

Removed the package lock file

@sonarqubecloud

Copy link
Copy Markdown

@mcollovati
mcollovati requested a review from caalador February 10, 2026 09:12
@caalador
caalador merged commit f4e5676 into 23.7 Feb 10, 2026
45 of 46 checks passed
@caalador
caalador deleted the fix/set-required-java-version-for-maven-plugin-23.7 branch February 10, 2026 09:13
vaadin-bot pushed a commit that referenced this pull request Feb 10, 2026
Prevents potential issues with Maven versions >= 3.9.12
if a Java version newer than the supported one is used
to package the Maven plugin.
vaadin-bot added a commit that referenced this pull request Feb 10, 2026
… (#23458)

Prevents potential issues with Maven versions >= 3.9.12
if a Java version newer than the supported one is used
to package the Maven plugin.

Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants