Skip to content

fix: Add popover attribute to system error container - #24093

Merged
mcollovati merged 11 commits into
mainfrom
web-components-11459
Apr 10, 2026
Merged

mcollovati merged 11 commits into
mainfrom
web-components-11459

Conversation

@TatuLund

@TatuLund TatuLund commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

E.g. Dialog can obscure the message

Fixes #24094

@github-actions github-actions Bot added the +0.0.1 label Apr 8, 2026
@github-actions

github-actions Bot commented Apr 8, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

 1 390 files  ±0   1 390 suites  ±0   1h 25m 42s ⏱️ + 2m 37s
 9 940 tests +1   9 869 ✅ +1  71 💤 ±0  0 ❌ ±0 
10 415 runs  +1  10 335 ✅ +1  80 💤 ±0  0 ❌ ±0 

Results for commit ac82d6b. ± Comparison against base commit adc6694.

♻️ This comment has been updated with latest results.

@mcollovati

Copy link
Copy Markdown
Collaborator

With the current version the notification is shown in the top-right corner of the screen. But with this change it is in the middle of the screen.
I think the appearance should not be changed.

@TatuLund

TatuLund commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

With the current version the notification is shown in the top-right corner of the screen. But with this change it is in the middle of the screen. I think the appearance should not be changed.

Ok, found a fix to that.

@mcollovati

Copy link
Copy Markdown
Collaborator

It would be good to add a test to InternalErrorIT to make sure notification is interactable under a modal component. I can add the test, if you don't mind

@mcollovati

Copy link
Copy Markdown
Collaborator

With the current version the notification is shown in the top-right corner of the screen. But with this change it is in the middle of the screen. I think the appearance should not be changed.

Ok, found a fix to that.

Now the notification is on the right but still vertically aligned in the middle.

image

@mcollovati mcollovati left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the position of the notification needs to be fixed

@mcollovati mcollovati added target/25.0 Cherry-pick to 25.0 branch target/25.1 labels Apr 9, 2026
@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2026

Copy link
Copy Markdown

@TatuLund

TatuLund commented Apr 10, 2026 •

Copy link
Copy Markdown
Contributor Author

the position of the notification needs to be fixed

@mcollovati Should be done now.

@mcollovati
mcollovati added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 8f42c5a Apr 10, 2026
31 checks passed
@mcollovati
mcollovati deleted the web-components-11459 branch April 10, 2026 08:30
vaadin-bot pushed a commit that referenced this pull request Apr 10, 2026
E.g. Dialog can obscure the message

Fixes #24094

---------

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot pushed a commit that referenced this pull request Apr 10, 2026
E.g. Dialog can obscure the message

Fixes #24094

---------

Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 10, 2026
….1) (#24104)

This PR cherry-picks changes from the original PR #24093 to branch 25.1.
---
#### Original PR description
> E.g. Dialog can obscure the message
> 
> Fixes #24094
>

Co-authored-by: Tatu Lund <tatu@vaadin.com>
Co-authored-by: Marco Collovati <marco@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 10, 2026
….0) (#24105)

This PR cherry-picks changes from the original PR #24093 to branch 25.0.
---
#### Original PR description
> E.g. Dialog can obscure the message
> 
> Fixes #24094
>

Co-authored-by: Tatu Lund <tatu@vaadin.com>
Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SystemMessages is shown behind Dialog

4 participants