Repository navigation
chore: pin maven-install-plugin to 3.1.4 - #25226
Conversation
|
@Artur- this "chore:"/"test:" PR has been approved automatically, but auto merge has not been enabled for it. You can enable the auto merge by yourself, or ask another member for another review. [Message is sent from bot] |
Maven 3.8.7, which CI pins, binds maven-install-plugin 2.4 through its default lifecycle bindings. That version predates the Resolver-based installer and still writes repository metadata through the legacy ArtifactInstaller API. The group level com/vaadin/maven-metadata-local.xml is shared by every maven-plugin packaging module, so flow-maven-plugin and flow-dev-bundle-plugin both write it during the -T builds CI runs. Pinning 3.1.4 puts installation on the Resolver API for every module regardless of which Maven version builds the project.
11b835b to
f6d673a
Compare
|
@Artur- this "chore:"/"test:" PR has been approved automatically, but auto merge has not been enabled for it. You can enable the auto merge by yourself, or ask another member for another review. [Message is sent from bot] |
|
|
@claude is this correct and would only updating the Maven version to 3.9 help? |
|
Claude finished @Artur-'s task in 1m 14s —— View job AnswerYes, the diagnosis is correct, and I dug into the repo to confirm the details. On correctness of the PR reasoning:
Would only updating the runtime Maven to 3.9 help?
Recommendation: keep this PR as-is (it's the robust fix). Optionally, as a separate follow-up, you could also bump the
|
The pin is backported to 25.2 separately, so keep this PR to the revert of the CI metadata cleanup workaround only.
|
Hi @Artur- and @Artur-, when i performed cherry-pick to this commit to 25.1, i have encountered the following issue. Can you take a look and pick it manually? |
This branch's copy of validation.yml had drifted a long way from main's. Since a pull_request workflow runs the copy of the file that lives on the PR's base branch, none of the fixes made on main since then have applied to pull requests against this branch. Ported over: - The auto-merge job, which approves cherry-picks and low-risk chore:/test:/refactor: pull requests. It has been on 24.9 and newer since it was introduced but never reached this branch, so pull requests here were never auto reviewed. It depends on test-results rather than on api-diff-labeling as it does on newer branches, because api-diff-labeling is gated on a pull_request_target event this workflow does not subscribe to and therefore never runs; the "+0.0.1" label that autoMerge.js looks for comes from the TeamCity API-DIFF labeling build instead. - Main's fork handling. Pull requests from forks now build but run no tests and see no secrets, replacing the pr-tests environment and the actions-cool/check-user-permission check, which tracked a floating @main ref. - Every action pinned to the commit main pins it to. pnpm/action-setup stays on v3, the version 25.2 pins, rather than main's v6, which pairs with pnpm 11 rather than the pnpm 8 this branch builds against. - TB_LICENSE passed through env instead of being interpolated into the body of a shell script. - always() for test-results. With failure() || success() the job is skipped when a matrix entry is cancelled, and a skipped required check satisfies branch protection, which would let auto-merge proceed past a cancelled IT. - The IT reliability fixes: a 22 minute step timeout, detaching mvn's stdio so an orphaned child JVM cannot pin the step open, killing leftover Java processes, and packaging test reports on cancellation. - A concurrency group that no longer expands to the literal string "<head_ref> || <ref_name>", and merge_group support. - Dropping the edited pull request trigger, which re-ran the whole suite when someone edited a PR title. It also picks up two changes from main that the cherry-pick bot could not apply here, because this branch's pom.xml uses different indentation and pins maven-jar-plugin literally rather than through a property: - Pinning maven-install-plugin to 3.1.4 (#25226). Maven 3.8 binds install:2.4 by default, which corrupts the group level com/vaadin/maven-metadata-local.xml when maven-plugin packaging modules install in parallel under -T. - Using the runner-provided Maven instead of setup-maven (#25265). The step downloads Maven on every job and times out intermittently, and the ubuntu-24.04 image already ships Maven 3.9.16. Deliberately not ported: the Sonar analysis, the coverage profile, the Javadoc-to-JUnit conversion and the spotless formatter workflow. All of them need build-side support that only exists on 25.2 and newer.
This PR cherry-picks changes from the original PR #25226 to branch 25.2. --- #### Original PR description > Maven 3.8.7, which CI pins, binds maven-install-plugin 2.4 through its > default lifecycle bindings. That version predates the Resolver-based > installer and still writes repository metadata through the legacy > ArtifactInstaller API. The group level com/vaadin/maven-metadata-local.xml > is shared by every maven-plugin packaging module, so flow-maven-plugin and > flow-dev-bundle-plugin both write it during the -T builds CI runs. > > Pinning 3.1.4 puts installation on the Resolver API for every module > regardless of which Maven version builds the project. > Co-authored-by: Artur Signell <artur@vaadin.com>
Maven 3.8.7, which CI pins, binds maven-install-plugin 2.4 through its default lifecycle bindings. That version predates the Resolver-based installer and still writes repository metadata through the legacy ArtifactInstaller API. The group level com/vaadin/maven-metadata-local.xml is shared by every maven-plugin packaging module, so flow-maven-plugin and flow-dev-bundle-plugin both write it during the -T builds CI runs. Pinning 3.1.4 puts installation on the Resolver API for every module regardless of which Maven version builds the project.
Maven 3.8.7, which CI pins, binds maven-install-plugin 2.4 through its default lifecycle bindings. That version predates the Resolver-based installer and still writes repository metadata through the legacy ArtifactInstaller API. The group level com/vaadin/maven-metadata-local.xml is shared by every maven-plugin packaging module, so flow-maven-plugin and flow-dev-bundle-plugin both write it during the -T builds CI runs. Pinning 3.1.4 puts installation on the Resolver API for every module regardless of which Maven version builds the project.
Maven 3.8.7, which CI pins, binds maven-install-plugin 2.4 through its default lifecycle bindings. That version predates the Resolver-based installer and still writes repository metadata through the legacy ArtifactInstaller API. The group level com/vaadin/maven-metadata-local.xml is shared by every maven-plugin packaging module, so flow-maven-plugin and flow-dev-bundle-plugin both write it during the -T builds CI runs. Pinning 3.1.4 puts installation on the Resolver API for every module regardless of which Maven version builds the project.
This PR cherry-picks changes from the original PR #25226 to branch 23.7. --- #### Original PR description > Maven 3.8.7, which CI pins, binds maven-install-plugin 2.4 through its > default lifecycle bindings. That version predates the Resolver-based > installer and still writes repository metadata through the legacy > ArtifactInstaller API. The group level com/vaadin/maven-metadata-local.xml > is shared by every maven-plugin packaging module, so flow-maven-plugin and > flow-dev-bundle-plugin both write it during the -T builds CI runs. > > Pinning 3.1.4 puts installation on the Resolver API for every module > regardless of which Maven version builds the project. Co-authored-by: Artur Signell <artur@vaadin.com>
This PR cherry-picks changes from the original PR #25226 to branch 24.9. --- #### Original PR description > Maven 3.8.7, which CI pins, binds maven-install-plugin 2.4 through its > default lifecycle bindings. That version predates the Resolver-based > installer and still writes repository metadata through the legacy > ArtifactInstaller API. The group level com/vaadin/maven-metadata-local.xml > is shared by every maven-plugin packaging module, so flow-maven-plugin and > flow-dev-bundle-plugin both write it during the -T builds CI runs. > > Pinning 3.1.4 puts installation on the Resolver API for every module > regardless of which Maven version builds the project. Co-authored-by: Artur Signell <artur@vaadin.com>
This PR cherry-picks changes from the original PR #25226 to branch 24.10. --- #### Original PR description > Maven 3.8.7, which CI pins, binds maven-install-plugin 2.4 through its > default lifecycle bindings. That version predates the Resolver-based > installer and still writes repository metadata through the legacy > ArtifactInstaller API. The group level com/vaadin/maven-metadata-local.xml > is shared by every maven-plugin packaging module, so flow-maven-plugin and > flow-dev-bundle-plugin both write it during the -T builds CI runs. > > Pinning 3.1.4 puts installation on the Resolver API for every module > regardless of which Maven version builds the project. Co-authored-by: Artur Signell <artur@vaadin.com>
This branch's copy of validation.yml had drifted from main's. Since a pull_request workflow runs the copy of the file that lives on the PR's base branch, none of the fixes made on main since then have applied to pull requests against this branch. Ported over: - Main's fork handling. Pull requests from forks now build but run no tests and see no secrets, replacing the pr-tests environment and the actions-cool/check-user-permission check, which tracked a floating @main ref. api-diff-labeling, which has write access to labels, is skipped for forks for the same reason. - Every action pinned to the commit main pins it to. pnpm/action-setup stays on v3, the version 25.2 pins, rather than main's v6, which pairs with pnpm 11 rather than the pnpm 8 this branch builds against. - TB_LICENSE passed through env instead of being interpolated into the body of a shell script. - The head sha is now checked out in build and it-tests as it already was in unit-tests. Those two jobs checked out the pull request merge ref instead, so the workspace build saved did not match the sources the unit tests restoring it ran against. - The IT reliability fixes: a 22 minute step timeout, detaching mvn's stdio so an orphaned child JVM cannot pin the step open, killing leftover Java processes, and packaging test reports on cancellation. - Dropping the base_ref != 'main' guard on auto-merge, which main removed when auto-merge was enabled there. - A concurrency group keyed on the merge group head sha, and merge_group support. It also picks up two changes from main that the cherry-pick bot could not apply here, because this branch's pom.xml uses different indentation and pins maven-jar-plugin literally rather than through a property: - Pinning maven-install-plugin to 3.1.4 (#25226). Maven 3.8 binds install:2.4 by default, which corrupts the group level com/vaadin/maven-metadata-local.xml when maven-plugin packaging modules install in parallel under -T. - Using the runner-provided Maven instead of setup-maven (#25265). The step downloads Maven on every job and times out intermittently, and the ubuntu-24.04 image already ships Maven 3.9.16. Deliberately not ported: the Sonar analysis, the coverage profile, the Javadoc-to-JUnit conversion and the spotless formatter workflow. All of them need build-side support that only exists on 25.2 and newer.
This branch's copy of validation.yml had drifted from main's. Since a pull_request workflow runs the copy of the file that lives on the PR's base branch, none of the fixes made on main since then have applied to pull requests against this branch. Ported over: - Main's fork handling. Pull requests from forks now build but run no tests and see no secrets, replacing the pr-tests environment and the actions-cool/check-user-permission check, which tracked a floating @main ref. api-diff-labeling, which has write access to labels, is skipped for forks for the same reason. - Every action pinned to the commit main pins it to. pnpm/action-setup stays on v3, the version 25.2 pins, rather than main's v6, which pairs with pnpm 11 rather than the pnpm 8 this branch builds against. - TB_LICENSE passed through env instead of being interpolated into the body of a shell script. - The head sha is now checked out in build and it-tests as it already was in unit-tests. Those two jobs checked out the pull request merge ref instead, so the workspace build saved did not match the sources the unit tests restoring it ran against. - The IT reliability fixes: a 22 minute step timeout, detaching mvn's stdio so an orphaned child JVM cannot pin the step open, killing leftover Java processes, and packaging test reports on cancellation. - Dropping the base_ref != 'main' guard on auto-merge, which main removed when auto-merge was enabled there. - A concurrency group keyed on the merge group head sha, and merge_group support. It also picks up two changes from main that the cherry-pick bot could not apply here, because this branch's pom.xml uses different indentation and pins maven-jar-plugin literally rather than through a property: - Pinning maven-install-plugin to 3.1.4 (#25226). Maven 3.8 binds install:2.4 by default, which corrupts the group level com/vaadin/maven-metadata-local.xml when maven-plugin packaging modules install in parallel under -T. - Using the runner-provided Maven instead of setup-maven (#25265). The step downloads Maven on every job and times out intermittently, and the ubuntu-24.04 image already ships Maven 3.9.16. Deliberately not ported: the Sonar analysis, the coverage profile, the Javadoc-to-JUnit conversion and the spotless formatter workflow. All of them need build-side support that only exists on 25.2 and newer.
This branch's copy of validation.yml had drifted a long way from main's. Since a pull_request workflow runs the copy of the file that lives on the PR's base branch, none of the fixes made on main since then have applied to pull requests against this branch. Ported over: - The auto-merge job, which approves cherry-picks and low-risk chore:/test:/refactor: pull requests. It has been on 24.9 and newer since it was introduced but never reached this branch, so pull requests here were never auto reviewed. It depends on test-results rather than on api-diff-labeling as it does on newer branches, because api-diff-labeling is gated on a pull_request_target event this workflow does not subscribe to and therefore never runs; the "+0.0.1" label that autoMerge.js looks for comes from the TeamCity API-DIFF labeling build instead. - Main's fork handling. Pull requests from forks now build but run no tests and see no secrets, replacing the pr-tests environment and the actions-cool/check-user-permission check, which tracked a floating @main ref. - Every action pinned to the commit main pins it to. pnpm/action-setup stays on v3, the version 25.2 pins, rather than main's v6, which pairs with pnpm 11 rather than the pnpm 8 this branch builds against. - TB_LICENSE passed through env instead of being interpolated into the body of a shell script. - always() for test-results. With failure() || success() the job is skipped when a matrix entry is cancelled, and a skipped required check satisfies branch protection, which would let auto-merge proceed past a cancelled IT. - The IT reliability fixes: a 22 minute step timeout, detaching mvn's stdio so an orphaned child JVM cannot pin the step open, killing leftover Java processes, and packaging test reports on cancellation. - A concurrency group that no longer expands to the literal string "<head_ref> || <ref_name>", and merge_group support. - Dropping the edited pull request trigger, which re-ran the whole suite when someone edited a PR title. It also picks up two changes from main that the cherry-pick bot could not apply here, because this branch's pom.xml uses different indentation and pins maven-jar-plugin literally rather than through a property: - Pinning maven-install-plugin to 3.1.4 (#25226). Maven 3.8 binds install:2.4 by default, which corrupts the group level com/vaadin/maven-metadata-local.xml when maven-plugin packaging modules install in parallel under -T. - Using the runner-provided Maven instead of setup-maven (#25265). The step downloads Maven on every job and times out intermittently, and the ubuntu-24.04 image already ships Maven 3.9.16. Deliberately not ported: the Sonar analysis, the coverage profile, the Javadoc-to-JUnit conversion and the spotless formatter workflow. All of them need build-side support that only exists on 25.2 and newer.
This branch's copy of validation.yml had drifted a long way from main's. Since a pull_request workflow runs the copy of the file that lives on the PR's base branch, none of the fixes made on main since then have applied to pull requests against this branch. Ported over: - The auto-merge job, which approves cherry-picks and low-risk chore:/test:/refactor: pull requests. It has been on 24.9 and newer since it was introduced but never reached this branch, so pull requests here were never auto reviewed. It depends on test-results rather than on api-diff-labeling as it does on newer branches, because api-diff-labeling is gated on a pull_request_target event this workflow does not subscribe to and therefore never runs; the "+0.0.1" label that autoMerge.js looks for comes from the TeamCity API-DIFF labeling build instead. - Main's fork handling. Pull requests from forks now build but run no tests and see no secrets, replacing the pr-tests environment and the actions-cool/check-user-permission check, which tracked a floating @main ref. - Every action pinned to the commit main pins it to. pnpm/action-setup stays on v3, the version 25.2 pins, rather than main's v6, which pairs with pnpm 11 rather than the pnpm 8 this branch builds against. - TB_LICENSE passed through env instead of being interpolated into the body of a shell script. - always() for test-results. With failure() || success() the job is skipped when a matrix entry is cancelled, and a skipped required check satisfies branch protection, which would let auto-merge proceed past a cancelled IT. - The IT reliability fixes: a 22 minute step timeout, detaching mvn's stdio so an orphaned child JVM cannot pin the step open, killing leftover Java processes, and packaging test reports on cancellation. - A concurrency group that no longer expands to the literal string "<head_ref> || <ref_name>", and merge_group support. - Dropping the edited pull request trigger, which re-ran the whole suite when someone edited a PR title. It also picks up two changes from main that the cherry-pick bot could not apply here, because this branch's pom.xml uses different indentation and pins maven-jar-plugin literally rather than through a property: - Pinning maven-install-plugin to 3.1.4 (#25226). Maven 3.8 binds install:2.4 by default, which corrupts the group level com/vaadin/maven-metadata-local.xml when maven-plugin packaging modules install in parallel under -T. - Using the runner-provided Maven instead of setup-maven (#25265). The step downloads Maven on every job and times out intermittently, and the ubuntu-24.04 image already ships Maven 3.9.16. Deliberately not ported: the Sonar analysis, the coverage profile, the Javadoc-to-JUnit conversion and the spotless formatter workflow. All of them need build-side support that only exists on 25.2 and newer.
…in (#25361) Since a pull_request workflow runs the copy of the file that lives on the PR's base branch, fixes made on main only reach pull requests against this branch once they are ported here. Ported over: - Main's fork handling. Pull requests from forks now build but run no tests and see no secrets, replacing the pr-tests environment. api-diff-labeling, which has write access to labels, is skipped for forks for the same reason. - Every action pinned to the commit main pins it to, including the two in sonar-pr.yml, which has no equivalent on main to copy from but was still tracking floating v4 tags. pnpm/action-setup stays on v3, the version 25.2 pins, rather than main's v6, which pairs with pnpm 11 rather than the pnpm 8 this branch builds against. - TB_LICENSE passed through env instead of being interpolated into the body of a shell script. - Dropping the base_ref != 'main' guard on auto-merge, which main removed when auto-merge was enabled there. - A concurrency group keyed on the merge group head sha, so re-running an obsolete merge queue validation cannot cancel the run validating the current merge group. - Dropping the base branch filter from the pull_request trigger in both workflows, so that pull requests stacked on another feature branch are validated and format checked too. PRs against an older maintenance branch keep using that branch's own copy of these files. It also picks up two changes from main that the cherry-pick bot could not apply here: - Pinning maven-install-plugin to 3.1.4 (#25226). Maven 3.8 binds install:2.4 by default, which corrupts the group level com/vaadin/maven-metadata-local.xml when maven-plugin packaging modules install in parallel under -T. - Using the runner-provided Maven instead of setup-maven (#25265). The step downloads Maven on every job and times out intermittently, and the ubuntu-24.04 image already ships Maven 3.9.16. Deliberately not ported: the Sonar analysis into validation.yml, the coverage profile it reads, and the Javadoc-to-JUnit conversion. All of them need build-side support that only exists on 25.2 and newer. Sonar keeps running from sonar-pr.yml on this branch. Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>



Maven 3.8.7, which CI pins, binds maven-install-plugin 2.4 through its
default lifecycle bindings. That version predates the Resolver-based
installer and still writes repository metadata through the legacy
ArtifactInstaller API. The group level com/vaadin/maven-metadata-local.xml
is shared by every maven-plugin packaging module, so flow-maven-plugin and
flow-dev-bundle-plugin both write it during the -T builds CI runs.
Pinning 3.1.4 puts installation on the Resolver API for every module
regardless of which Maven version builds the project.