Skip to content

ci: bring the 24.9 validation workflow closer to main - #25435

Merged
Artur- merged 1 commit into
24.9from
ci-sync-24.9-validation-workflow-with-main
Sep 5, 2026
Merged

Artur- merged 1 commit into
24.9from
ci-sync-24.9-validation-workflow-with-main

Conversation

@totally-not-ai

@totally-not-ai totally-not-ai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Ports the three branch-agnostic validation-workflow fixes that already landed on 25.2 and 25.1. None of them are main-specific.

What changed

1. Bump pnpm/action-setup v3.0.0 → v6.0.9 (#25115)

The old pinned action runs on a deprecated Actions runtime. The pnpm version the action installs is unchanged — it stays at this branch's own 8.15.9.

2. Truncate the Maven log before the build starts (unit test and IT jobs)

Both jobs write the build output to mvn-*-tests-*.out and follow it with tail -f. On a re-run the log restored from the workspace tarball still contains the previous attempt's output, so tail -f replays it into the step log before any new output appears. Adding : > "$LOG" right before launching Maven starts each attempt from an empty file.

3. Guard the auto-merge job on VAADIN_BOT_TOKEN

A Dependabot-triggered run is given the Dependabot secret store instead of the Actions one, so secrets.VAADIN_BOT_TOKEN is empty and the vaadin/platform-build-script checkout fails the job. The secrets context can't be read from a job-level if:, so the token is bound to a job env var and each step that needs it is guarded on env.VAADIN_BOT_TOKEN != ''. When the token is missing the job now writes a note to the step summary and skips instead of failing.

What was deliberately not ported

The remaining differences from main on this branch — Node/pnpm versions, Sonar setup, test matrix width, and the api-diff comparison strategy — are per-branch policy rather than drift, so they are left alone.

The same three branch-agnostic fixes that were ported to 25.2 and 25.1,
none of which are main-specific:

- Bump pnpm/action-setup from v3.0.0 to v6.0.9 (#25115), so the job stops
  running on a deprecated Actions runtime. The pnpm version the action
  installs is left at this branch's own 8.15.9.
- Truncate the Maven log before starting the build in the unit test and IT
  jobs. On a re-run the log restored from the workspace tarball still holds
  the previous attempt's output, which `tail -f` then replays.
- Guard the auto-merge job on VAADIN_BOT_TOKEN. A Dependabot-triggered run
  gets the Dependabot secret store instead of the Actions one, so the token
  is empty and the platform-build-script checkout fails; the job now skips
  with a note in the step summary instead.

Only these three are ported. The remaining differences from main on this
branch (Node/pnpm versions, Sonar setup, test matrix width, api-diff
comparison strategy) are per-branch policy rather than drift.
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Test Results

1 195 files  ± 0  1 195 suites  ±0   1h 11m 17s ⏱️ - 3m 28s
8 961 tests ± 0  8 899 ✅ ± 0  62 💤 ±0  0 ❌ ±0 
9 123 runs   - 78  9 060 ✅  - 77  63 💤  - 1  0 ❌ ±0 

Results for commit 23a875d. ± Comparison against base commit 5288b72.

@github-actions github-actions Bot added the +0.0.1 label Sep 3, 2026
@Artur-
Artur- merged commit a12b30e into 24.9 Sep 5, 2026
48 of 49 checks passed
@Artur-
Artur- deleted the ci-sync-24.9-validation-workflow-with-main branch September 5, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant