Repository navigation
fix: keep components with JS initializers serializable (#25439) (CP: 25.2) - #25440
Merged
Merged
Conversation
## Description `addAttachListener` returns a registration that captures the listener, and `ElementJsInitializerRegistration` keeps that registration in a field of the same object. When the listener is a lambda or method reference, the two form a cycle that Java's lambda deserialization cannot resolve: the captured listener comes back as an unresolved `SerializedLambda` and the cast to `Command` fails. Session serialization of any element carrying a JS initializer therefore failed with a `ClassCastException`. - Replaced the method-reference attach listener in `ElementJsInitializerRegistration` with an explicit `Command` implementation, so it no longer serializes as a `SerializedLambda` - Added `ElementTest#addJsInitializer_serializeAndDeserializeOwner_succeeds`, which serializes and deserializes the state node of an element that carries an initializer ## Type of change - Bugfix Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Leif Åstrand <leif@vaadin.com>
Collaborator
Author
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot] |
vaadin-review-bot
approved these changes
Sep 2, 2026
vaadin-bot
enabled auto-merge (squash)
September 2, 2026 12:15
|
Contributor
Collaborator
Author
|
This ticket/PR has been released with Vaadin 25.2.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR cherry-picks changes from the original PR #25439 to branch 25.2.
Original PR description