Repository navigation
fix(devloop): spawn the dev-loop daemon in a session of its own - #25516
Merged
Merged
Conversation
A nohup'd daemon stays in the process group of the command that spawned it, and the runners vaadin-dev is driven from - agent sandboxes, CI steps, timeout --kill-after - end a command by killing that group. The daemon and the application it owned died with the very command that started them, so every later command found a stale handshake, spawned a fresh daemon and reported the app as stopped: the loop never held across two commands. setsid, or perl's POSIX::setsid where no setsid binary ships, puts it out of reach of that kill. A handshake left behind by a dead pid is now reported instead of quietly reaped, since a daemon that shuts down deletes its own. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
mshabarov
approved these changes
Sep 7, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.3.0-beta2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



A nohup'd daemon stays in the process group of the command that spawned it, and the runners vaadin-dev is driven from - agent sandboxes, CI steps, timeout --kill-after - end a command by killing that group. The daemon and the application it owned died with the very command that started them, so every later command found a stale handshake, spawned a fresh daemon and reported the app as stopped: the loop never held across two commands.
setsid, or perl's POSIX::setsid where no setsid binary ships, puts it out of reach of that kill. A handshake left behind by a dead pid is now reported instead of quietly reaped, since a daemon that shuts down deletes its own.