Repository navigation
fix(plugins): drop development entries from production token file (CP: 24.10) (#25872) (CP: 24.9) - #25879
Merged
Conversation
…: 24.10) (#25872) Related to #25856 Depends on #25871 **behavior deviation** · flow-plugins · Gradle builds that always run prepare-frontend Backport of #25871 to 24.10. **Background — the token file.** `META-INF/VAADIN/config/flow-build-info.json` carries the configuration the build hands over to the runtime. `prepare-frontend` writes a development version of it, with the absolute paths of the machine that runs the build, and `build-frontend` rewrites it for production by removing those entries one by one. One entry was missing from that removal list. A Gradle application built with `alwaysExecutePrepareFrontend` is packaged with `disable.prepare.frontend.cache`, a flag only the build uses. It does not change how the application runs, but it does not belong in a distributed artifact. **Risks:** -⚠️ Behaviour change: a production application built with `alwaysExecutePrepareFrontend` no longer reports the `flow/always-execute-prepare-frontend` usage statistic. It was reported from the build time flag, which the runtime has no use for. - ✅ No breaking change, no public API change, nothing security, memory, serialization, threading or performance related, no migration needed. **Context.** The removal list is a deny list: an entry added to the development token file is kept in production unless somebody remembers to add it to the list as well. `disable.prepare.frontend.cache` was added later than the list and was never included. The branch differs from `main` here: `node.folder`, the second entry removed there, does not exist on 24.10, so this backport is the single removal. - Removed `disable.prepare.frontend.cache` from the production token file. It only tells the build whether to skip its cache check. - Rewrote the test for the production token file so that it asserts the exact set of entries instead of only checking that something was removed, which is why this drift was not caught earlier.
Contributor
Collaborator
Author
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot] |
vaadin-review-bot
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #25872 to branch 24.9.
Original PR description