Skip to content

fix(plugins): drop development entries from production token file (CP: 24.10) (#25872) (CP: 24.9) - #25879

Merged
vaadin-bot merged 1 commit into
24.9from
cherry-pick-25872-to-24.9-1790092844973
Sep 22, 2026
Merged

vaadin-bot merged 1 commit into
24.9from
cherry-pick-25872-to-24.9-1790092844973

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #25872 to branch 24.9.

Original PR description

Related to #25856
Depends on #25871

behavior deviation · flow-plugins · Gradle builds that always run
prepare-frontend

Backport of #25871 to 24.10.

Background — the token file. META-INF/VAADIN/config/flow-build-info.json
carries the configuration the build hands over to the runtime.
prepare-frontend writes a development version of it, with the absolute
paths of the machine that runs the build, and build-frontend rewrites it
for production by removing those entries one by one.

One entry was missing from that removal list. A Gradle application built
with alwaysExecutePrepareFrontend is packaged with
disable.prepare.frontend.cache, a flag only the build uses. It does not
change how the application runs, but it does not belong in a distributed
artifact.

Risks:

  • ⚠️ Behaviour change: a production application built with
    alwaysExecutePrepareFrontend no longer reports the
    flow/always-execute-prepare-frontend usage statistic. It was reported
    from the build time flag, which the runtime has no use for.
  • ✅ No breaking change, no public API change, nothing security, memory,
    serialization, threading or performance related, no migration needed.

Context. The removal list is a deny list: an entry added to the
development token file is kept in production unless somebody remembers to
add it to the list as well. disable.prepare.frontend.cache was added later
than the list and was never included. The branch differs from main here:
node.folder, the second entry removed there, does not exist on 24.10, so
this backport is the single removal.

  • Removed disable.prepare.frontend.cache from the production token file.
    It only tells the build whether to skip its cache check.
  • Rewrote the test for the production token file so that it asserts the
    exact set of entries instead of only checking that something was removed,
    which is why this drift was not caught earlier.

…: 24.10) (#25872)

Related to #25856
Depends on #25871

**behavior deviation** · flow-plugins · Gradle builds that always run
prepare-frontend

Backport of #25871 to 24.10.

**Background — the token file.**
`META-INF/VAADIN/config/flow-build-info.json`
carries the configuration the build hands over to the runtime.
`prepare-frontend` writes a development version of it, with the absolute
paths of the machine that runs the build, and `build-frontend` rewrites
it
for production by removing those entries one by one.

One entry was missing from that removal list. A Gradle application built
with `alwaysExecutePrepareFrontend` is packaged with
`disable.prepare.frontend.cache`, a flag only the build uses. It does
not
change how the application runs, but it does not belong in a distributed
artifact.

**Risks:**
- ⚠️ Behaviour change: a production application built with
  `alwaysExecutePrepareFrontend` no longer reports the
`flow/always-execute-prepare-frontend` usage statistic. It was reported
  from the build time flag, which the runtime has no use for.
- ✅ No breaking change, no public API change, nothing security, memory,
  serialization, threading or performance related, no migration needed.

**Context.** The removal list is a deny list: an entry added to the
development token file is kept in production unless somebody remembers
to
add it to the list as well. `disable.prepare.frontend.cache` was added
later
than the list and was never included. The branch differs from `main`
here:
`node.folder`, the second entry removed there, does not exist on 24.10,
so
this backport is the single removal.

- Removed `disable.prepare.frontend.cache` from the production token
file.
  It only tells the build whether to skip its cache check.
- Rewrote the test for the production token file so that it asserts the
exact set of entries instead of only checking that something was
removed,
  which is why this drift was not caught earlier.
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

1 195 files  ± 0  1 195 suites  ±0   1h 2m 49s ⏱️ + 4m 37s
8 961 tests ± 0  8 899 ✅ ± 0  62 💤 ±0  0 ❌ ±0 
9 203 runs  +65  9 138 ✅ +65  65 💤 ±0  0 ❌ ±0 

Results for commit 8a2f9f6. ± Comparison against base commit 6e76344.

@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@vaadin-bot
vaadin-bot merged commit bf7bf68 into 24.9 Sep 22, 2026
48 of 49 checks passed
@vaadin-bot
vaadin-bot deleted the cherry-pick-25872-to-24.9-1790092844973 branch September 22, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants