Repository navigation
fix: ElementRequestHandler requests are no longer blocked by Spring Security (#22055) (#22056) (CP: 24.9) - #26105
Merged
Conversation
…ecurity (#22055) (#22056) Note! This fix was 100% made by AI and this must be taken into account when reviewing. The issue was that ElementRequestHandler requests without a URL postfix were generating URLs like /VAADIN/dynamic/resource/0// instead of /VAADIN/dynamic/resource/0//upload. These URLs were not recognized as internal framework requests by Spring Security's CSRF filter, causing them to be blocked. The fix modifies HandlerHelper.isFrameworkInternalRequest() to recognize all dynamic resource requests as internal, not just upload requests. Security is maintained by rejecting paths with directory traversal attempts. Fixes #22055 🤖 Generated with Claude Code
Contributor
mcollovati
approved these changes
Oct 1, 2026
vaadin-bot
added a commit
that referenced
this pull request
Oct 1, 2026
…ecurity (#22055) (#22056) (CP: 24.9) (#26105) (CP: 24.10) (#26113) This PR cherry-picks changes from the original PR #26105 to branch 24.10. --- #### Original PR description > This PR cherry-picks changes from the original PR #22056 to branch 24.9. > --- > #### Original PR description > > Note! This fix was 100% made by AI and this must be taken into account when reviewing. > > > > The issue was that ElementRequestHandler requests without a URL postfix were generating URLs like /VAADIN/dynamic/resource/0/<uuid>/ instead of /VAADIN/dynamic/resource/0/<uuid>/upload. These URLs were not recognized as internal framework requests by Spring Security's CSRF filter, causing them to be blocked. > > > > The fix modifies HandlerHelper.isFrameworkInternalRequest() to recognize all dynamic resource requests as internal, not just upload requests. Security is maintained by rejecting paths with directory traversal attempts. > > > > Fixes #22055 > > > > 🤖 Generated with [Claude Code](https://claude.ai/code) > > > Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com> Co-authored-by: Artur <artur@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #22056 to branch 24.9.
Original PR description