Skip to content

fix: ElementRequestHandler requests are no longer blocked by Spring Security (#22055) (#22056) (CP: 24.9) - #26105

Merged
mcollovati merged 1 commit into
24.9from
cherry-pick-22056-to-24.9-1790839031821
Oct 1, 2026
Merged

mcollovati merged 1 commit into
24.9from
cherry-pick-22056-to-24.9-1790839031821

Conversation

@totally-not-ai

@totally-not-ai totally-not-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

This PR cherry-picks changes from the original PR #22056 to branch 24.9.

Original PR description

Note! This fix was 100% made by AI and this must be taken into account when reviewing.

The issue was that ElementRequestHandler requests without a URL postfix were generating URLs like /VAADIN/dynamic/resource/0// instead of /VAADIN/dynamic/resource/0//upload. These URLs were not recognized as internal framework requests by Spring Security's CSRF filter, causing them to be blocked.

The fix modifies HandlerHelper.isFrameworkInternalRequest() to recognize all dynamic resource requests as internal, not just upload requests. Security is maintained by rejecting paths with directory traversal attempts.

Fixes #22055

🤖 Generated with Claude Code

…ecurity (#22055) (#22056)

Note! This fix was 100% made by AI and this must be taken into account when reviewing.

The issue was that ElementRequestHandler requests without a URL postfix were generating URLs like /VAADIN/dynamic/resource/0// instead of /VAADIN/dynamic/resource/0//upload. These URLs were not recognized as internal framework requests by Spring Security's CSRF filter, causing them to be blocked.

The fix modifies HandlerHelper.isFrameworkInternalRequest() to recognize all dynamic resource requests as internal, not just upload requests. Security is maintained by rejecting paths with directory traversal attempts.

Fixes #22055

🤖 Generated with Claude Code
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Test Results

1 195 files  ± 0  1 195 suites  ±0   1h 3m 32s ⏱️ + 2m 59s
8 966 tests + 2  8 904 ✅ + 2  62 💤 ±0  0 ❌ ±0 
9 234 runs   - 23  9 168 ✅  - 24  66 💤 +1  0 ❌ ±0 

Results for commit 7f4e029. ± Comparison against base commit c307054.

@mcollovati
mcollovati merged commit a86544d into 24.9 Oct 1, 2026
33 checks passed
@mcollovati
mcollovati deleted the cherry-pick-22056-to-24.9-1790839031821 branch October 1, 2026 09:56
vaadin-bot added a commit that referenced this pull request Oct 1, 2026
…ecurity (#22055) (#22056) (CP: 24.9) (#26105) (CP: 24.10) (#26113)

This PR cherry-picks changes from the original PR #26105 to branch
24.10.
---
#### Original PR description
> This PR cherry-picks changes from the original PR #22056 to branch
24.9.
> ---
> #### Original PR description
> > Note! This fix was 100% made by AI and this must be taken into
account when reviewing.
> > 
> > The issue was that ElementRequestHandler requests without a URL
postfix were generating URLs like /VAADIN/dynamic/resource/0/<uuid>/
instead of /VAADIN/dynamic/resource/0/<uuid>/upload. These URLs were not
recognized as internal framework requests by Spring Security's CSRF
filter, causing them to be blocked.
> > 
> > The fix modifies HandlerHelper.isFrameworkInternalRequest() to
recognize all dynamic resource requests as internal, not just upload
requests. Security is maintained by rejecting paths with directory
traversal attempts.
> > 
> > Fixes #22055
> > 
> > 🤖 Generated with [Claude Code](https://claude.ai/code)
> > 
>

Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
Co-authored-by: Artur <artur@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants