Skip to content

fix: match old browser check to supported browsers (#26191) (CP: 25.3) - #26193

Merged
vaadin-bot merged 1 commit into
25.3from
cherry-pick-26191-to-25.3-1791273054938
Oct 6, 2026
Merged

vaadin-bot merged 1 commit into
25.3from
cherry-pick-26191-to-25.3-1791273054938

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #26191 to branch 25.3.

Original PR description

behavior deviation · flow-server · users on Firefox 128 ESR, Safari 17.0-17.4 or Chrome older than 123

The page that tells users their browser is too old only appeared for browsers without popover support (Chrome 114, Firefox 125, Safari 17.0). Firefox 128 ESR and early Safari 17 releases got past it, even though the frontend is built for Firefox 140 ESR and Safari 17.6, so they could load an app that does not work. The check now matches the supported browsers.

Risks:

  • ⚠️ Behaviour change: Firefox before 140 (including 128 ESR), Safari 17.0-17.4 and Chrome/Edge 114-122 now get the "old browser" page instead of the app. These versions are below the browsers Vaadin supports.
  • ✅ No API, security, memory, serialization, threading or performance impact.

Context. The build target in vite.generated.ts is Chrome/Edge 152, Firefox 140 and Safari 17.6. The check stays feature detection, and is a bit more lenient on Chrome so that users a few versions behind evergreen are not blocked.

  • Replaced the popover check in IndexHtmlRequestHandler with two feature checks: the CSS Custom Highlight API (Firefox 140, Chrome 105, Safari 17.2) and light-dark() (Firefox 120, Chrome 123, Safari 17.5), which together allow Chrome/Edge 123+, Firefox 140+ and Safari 17.5+.
  • Added a note at the build target in vite.generated.ts to keep the check in line with it.

**behavior deviation** · flow-server · users on Firefox 128 ESR, Safari
17.0-17.4 or Chrome older than 123

The page that tells users their browser is too old only appeared for
browsers without `popover` support (Chrome 114, Firefox 125, Safari
17.0). Firefox 128 ESR and early Safari 17 releases got past it, even
though the frontend is built for Firefox 140 ESR and Safari 17.6, so
they could load an app that does not work. The check now matches the
supported browsers.

**Risks:**
- ⚠️ Behaviour change: Firefox before 140 (including 128 ESR), Safari
17.0-17.4 and Chrome/Edge 114-122 now get the "old browser" page instead
of the app. These versions are below the browsers Vaadin supports.
- ✅ No API, security, memory, serialization, threading or performance
impact.

**Context.** The build target in `vite.generated.ts` is Chrome/Edge 152,
Firefox 140 and Safari 17.6. The check stays feature detection, and is a
bit more lenient on Chrome so that users a few versions behind evergreen
are not blocked.

- Replaced the `popover` check in `IndexHtmlRequestHandler` with two
feature checks: the CSS Custom Highlight API (Firefox 140, Chrome 105,
Safari 17.2) and `light-dark()` (Firefox 120, Chrome 123, Safari 17.5),
which together allow Chrome/Edge 123+, Firefox 140+ and Safari 17.5+.
- Added a note at the build target in `vite.generated.ts` to keep the
check in line with it.

Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
@github-actions github-actions Bot added the +0.0.1 label Oct 6, 2026
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@vaadin-bot
vaadin-bot enabled auto-merge (squash) October 6, 2026 08:00
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Test Results

 1 503 files  ±0   1 588 suites  ±0   1h 55m 43s ⏱️ - 5m 44s
11 968 tests ±0  11 900 ✅ ±0  68 💤 ±0  0 ❌ ±0 
12 536 runs  ±0  12 468 ✅ ±0  68 💤 ±0  0 ❌ ±0 

Results for commit 4456832. ± Comparison against base commit bc02736.

@vaadin-bot
vaadin-bot merged commit 1c9c712 into 25.3 Oct 6, 2026
@vaadin-bot
vaadin-bot deleted the cherry-pick-26191-to-25.3-1791273054938 branch October 6, 2026 08:13
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 25.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants