Repository navigation
fix: match old browser check to supported browsers (#26191) (CP: 25.3) - #26193
Merged
Merged
Conversation
**behavior deviation** · flow-server · users on Firefox 128 ESR, Safari 17.0-17.4 or Chrome older than 123 The page that tells users their browser is too old only appeared for browsers without `popover` support (Chrome 114, Firefox 125, Safari 17.0). Firefox 128 ESR and early Safari 17 releases got past it, even though the frontend is built for Firefox 140 ESR and Safari 17.6, so they could load an app that does not work. The check now matches the supported browsers. **Risks:** -⚠️ Behaviour change: Firefox before 140 (including 128 ESR), Safari 17.0-17.4 and Chrome/Edge 114-122 now get the "old browser" page instead of the app. These versions are below the browsers Vaadin supports. - ✅ No API, security, memory, serialization, threading or performance impact. **Context.** The build target in `vite.generated.ts` is Chrome/Edge 152, Firefox 140 and Safari 17.6. The check stays feature detection, and is a bit more lenient on Chrome so that users a few versions behind evergreen are not blocked. - Replaced the `popover` check in `IndexHtmlRequestHandler` with two feature checks: the CSS Custom Highlight API (Firefox 140, Chrome 105, Safari 17.2) and `light-dark()` (Firefox 120, Chrome 123, Safari 17.5), which together allow Chrome/Edge 123+, Firefox 140+ and Safari 17.5+. - Added a note at the build target in `vite.generated.ts` to keep the check in line with it. Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
Collaborator
Author
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot] |
vaadin-review-bot
approved these changes
Oct 6, 2026
vaadin-bot
enabled auto-merge (squash)
October 6, 2026 08:00
|
Contributor
Collaborator
Author
|
This ticket/PR has been released with Vaadin 25.3.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR cherry-picks changes from the original PR #26191 to branch 25.3.
Original PR description