Repository navigation
fix(devloop): cap future-dated file times in the change baseline (#26228) (CP: 25.3) - #26259
Merged
Merged
Conversation
) **Review risk:** two-way door — dev loop daemon only; affects how change detection treats files dated in the future **behavior deviation** · flow-devloop-daemon · projects whose files are dated ahead of the local clock With the dev loop, every `apply` restarted the application even when nothing was edited, first with "application.properties changed" and, once that was out of the way, because unchanged Java sources were recompiled each time. This happens when project files carry a modification time in the future, for example a starter zip extracted in a time zone behind the one it was packed in. It lasted until the clock caught up, hours later. Workaround: `touch` the affected files. **Risks:** -⚠️ Behaviour change: a file dated more than a minute ahead of the clock is now taken as read at startup, and its time is no longer compared with its compiled class. An edit always gets the current time, so this does not hide a real edit. -⚠️ Edge case: a future-dated source whose existing `.class` was built from different content (an archive shipping prebuilt classes) is not recompiled on timestamp grounds until it is edited. A real edit cannot cause this. - ✅ No public API, security, memory, serialization, threading, performance or migration impact **Context.** Change detection asks two timestamp questions: was the file written after the app started (the baseline), and is the source newer than its class file (the artifact check). A file dated in the future answers yes to both for hours: a startup-only resource restarted the app on every apply, and a future-dated source was recompiled on every apply, restarting the app when it was an entity. - Modification times more than 60 s ahead of the clock are now capped when seeding the baseline for sources, resources and frontend files - The 60 s margin keeps real edits on shares or container mounts with a slightly faster clock visible - The source-versus-class time check now skips sources dated more than 60 s ahead; the baseline still catches edits to them - Added tests for a future-dated `application.properties` and a future-dated source, both unchanged and edited --------- Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com> Co-authored-by: Artur Signell <artur@vaadin.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Tomi Virtanen <tltv@vaadin.com>
vaadin-review-bot
approved these changes
Oct 8, 2026
Collaborator
Author
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot] |
vaadin-bot
enabled auto-merge (squash)
October 8, 2026 15:02
|
Contributor
Collaborator
Author
|
This ticket/PR has been released with Vaadin 25.3.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR cherry-picks changes from the original PR #26228 to branch 25.3.