Skip to content

fix: zip file extractor (#23125) (CP: 24.7) - #26635

Merged
mcollovati merged 1 commit into
24.7from
bp24.7
Oct 22, 2026
Merged

mcollovati merged 1 commit into
24.7from
bp24.7

Conversation

@manolo

@manolo manolo commented Oct 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Cherry pick of b13f711, the 24.9 backport of fix: zip file extractor #23125, which applies here unchanged.
  • The zip extractor used when the build installs Node now resolves each entry against the target directory and refuses one that lands outside it.
  • The test that comes with it passes: 4 run, 0 failures in DefaultArchiveExtractorTest.

Context

The fix went to main, 25.0, 2.13, 24.9 and 23.6 in October. 24.4 and 24.7 were the two maintained lines left without it.

Cherry picked from b13f711, the 24.9 backport, which applies unchanged here.
@mcollovati
mcollovati enabled auto-merge (squash) October 22, 2026 14:27
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

1 118 files  ±0  1 118 suites  ±0   1h 5m 14s ⏱️ + 7m 17s
7 858 tests +1  7 802 ✅ +1  56 💤 ±0  0 ❌ ±0 
8 134 runs   - 4  8 072 ✅  - 5  62 💤 +1  0 ❌ ±0 

Results for commit ebb1dff. ± Comparison against base commit 06ec242.

@mcollovati
mcollovati merged commit fcd3334 into 24.7 Oct 22, 2026
33 checks passed
@mcollovati
mcollovati deleted the bp24.7 branch October 22, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants